Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing in icon4pytools #267

Merged
merged 15 commits into from
Sep 21, 2023
Merged

Fix typing in icon4pytools #267

merged 15 commits into from
Sep 21, 2023

Conversation

samkellerhals
Copy link
Contributor

@samkellerhals samkellerhals commented Sep 7, 2023 •
edited
Loading

Fixes all mypy related issues in icon4pytools.

Includes:
liskov
py2f
icon4pygen
f2ser

@samkellerhals samkellerhals marked this pull request as draft September 7, 2023 15:20
egparedes
egparedes requested changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. I have some questions and some docstrings are out of sync with the type annotations.

tools/src/icon4pytools/f2ser/deserialise.py Outdated Show resolved Hide resolved
tools/src/icon4pytools/f2ser/deserialise.py Outdated Show resolved Hide resolved
tools/src/icon4pytools/f2ser/deserialise.py Show resolved Hide resolved
tools/src/icon4pytools/f2ser/deserialise.py Outdated Show resolved Hide resolved
tools/src/icon4pytools/f2ser/parse.py Outdated Show resolved Hide resolved
tools/src/icon4pytools/f2ser/parse.py Show resolved Hide resolved
tools/src/icon4pytools/f2ser/parse.py Show resolved Hide resolved
tools/src/icon4pytools/liskov/codegen/serialisation/template.py Outdated Show resolved Hide resolved
tools/src/icon4pytools/liskov/external/metadata.py Outdated Show resolved Hide resolved
tools/src/icon4pytools/liskov/parsing/transform.py Show resolved Hide resolved
egparedes
egparedes requested changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's getting better but I still have some comments.

tools/src/icon4pytools/f2ser/deserialise.py Outdated Show resolved Hide resolved
tools/src/icon4pytools/f2ser/deserialise.py Outdated Show resolved Hide resolved
tools/src/icon4pytools/icon4pygen/bindings/codegen/cpp.py Outdated Show resolved Hide resolved
tools/src/icon4pytools/icon4pygen/bindings/codegen/f90.py Outdated Show resolved Hide resolved
tools/src/icon4pytools/icon4pygen/bindings/codegen/f90.py Outdated Show resolved Hide resolved
tools/src/icon4pytools/icon4pygen/bindings/entities.py Outdated Show resolved Hide resolved
tools/src/icon4pytools/icon4pygen/metadata.py Outdated Show resolved Hide resolved
tools/src/icon4pytools/liskov/codegen/integration/template.py Show resolved Hide resolved
tools/src/icon4pytools/liskov/codegen/integration/template.py Outdated Show resolved Hide resolved
tools/src/icon4pytools/liskov/parsing/types.py Outdated Show resolved Hide resolved
egparedes
egparedes reviewed Sep 21, 2023
View reviewed changes
tools/pyproject.toml Outdated Show resolved Hide resolved
@samkellerhals samkellerhals marked this pull request as ready for review September 21, 2023 10:33
egparedes
egparedes approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

@github-actions
Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • launch jenkins spack

Optional Tests

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@samkellerhals samkellerhals merged commit 92e23fb into main Sep 21, 2023
@samkellerhals samkellerhals deleted the fix-typing-icon4pytools branch September 21, 2023 11:59
ninaburg pushed a commit that referenced this pull request Sep 27, 2023
@samkellerhals
Fix typing in icon4pytools (#267)
6358ce9 
Fix static typing annotations in icon4pytools.
OngChia pushed a commit that referenced this pull request Jan 14, 2025
@samkellerhals
Fix typing in icon4pytools (#267)
e023796 
Fix static typing annotations in icon4pytools.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egparedes egparedes egparedes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samkellerhals @egparedes