Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pre levelmask from vel adv because cfl_clipping is the same thing #258

Merged
merged 6 commits into from
Aug 30, 2023
Merged

Remove pre levelmask from vel adv because cfl_clipping is the same thing #258

merged 6 commits into from
Aug 30, 2023

Conversation

muellch
Copy link
Contributor

@muellch muellch commented Aug 16, 2023

No description provided.

@muellch muellch force-pushed the remove_pre_levelmask_from_vel_adv branch from 70b6d83 to 70be0f0 Compare August 16, 2023 17:35
@muellch
Copy link
Contributor Author

muellch commented Aug 23, 2023

launch jenkins spack

@muellch muellch requested a review from abishekg7 August 23, 2023 08:47
@abishekg7 abishekg7 requested a review from halungge August 24, 2023 14:37
abishekg7
abishekg7 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@abishekg7 abishekg7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@abishekg7
Copy link
Contributor

spack build with gt4py@main will fail due to the new nanobind requirement. Can ignore as a PR has been opened for it separately.

halungge
halungge approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@halungge halungge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I only suggest porting the test for mo_velocity_advection_stencil_20 to the new format if possible.

model/atmosphere/dycore/tests/test_mo_velocity_advection_stencil_20.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not also port it to the new format using the StencilTest? Or is there a reason why this is not possible for this stencil?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but I will do that as a follow up. For now it is important that everyone gets the fixes, so they can run the correct code.
I can put the tests into the new format on my fused velocity advection branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

model/atmosphere/dycore/tests/test_mo_velocity_advection_stencil_20.py Outdated Show resolved Hide resolved
@github-actions
Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • launch jenkins spack

Optional Tests

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@muellch muellch requested a review from halungge August 25, 2023 16:22
abishekg7 added a commit that referenced this pull request Aug 28, 2023
@abishekg7
Bringing in bug fixes from @muellch #258
141fde6
@muellch muellch merged commit f929579 into main Aug 30, 2023
abishekg7 added a commit that referenced this pull request Sep 4, 2023
@abishekg7
pulling @muellch bug fixes from #258
f59098b
abishekg7 added a commit that referenced this pull request Sep 18, 2023
@abishekg7
fixes from @muellch from #258
280db1e
abishekg7 added a commit that referenced this pull request Sep 26, 2023
@abishekg7
fixes from @muellch from #258
5a6e836
abishekg7 added a commit that referenced this pull request Sep 26, 2023
@abishekg7
fixes from @muellch from #258
565f8d6
@samkellerhals samkellerhals deleted the remove_pre_levelmask_from_vel_adv branch December 20, 2024 08:38
OngChia pushed a commit that referenced this pull request Jan 14, 2025
@muellch
Remove pre_levelmask from vel. advection and fix bugs (#258)
7d47734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abishekg7 abishekg7 abishekg7 approved these changes

@halungge halungge halungge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muellch @abishekg7 @halungge