Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Dawn Headers #138

Merged
merged 6 commits into from
Mar 1, 2023
Merged

Rework Dawn Headers #138

merged 6 commits into from
Mar 1, 2023

Conversation

mroethlin
Copy link
Contributor

@mroethlin mroethlin commented Jan 5, 2023

This PR implements the new interfaces to the dawn headers due to the refactoring here .

@mroethlin mroethlin changed the title DO NOT MERGE: Rework Dawn Headers Rework Dawn Headers Feb 21, 2023
@mroethlin mroethlin marked this pull request as ready for review February 21, 2023 14:43
@mroethlin mroethlin requested a review from muellch February 21, 2023 14:48
Copy link
Contributor

@muellch muellch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left one comment we can address in a later PR.

pyutils/src/icon4py/bindings/codegen/cpp.py Show resolved Hide resolved
@mroethlin mroethlin merged commit c10067a into main Mar 1, 2023
@samkellerhals samkellerhals deleted the refac_dawn_headers branch May 25, 2023 07:31
OngChia pushed a commit that referenced this pull request Jan 14, 2025
This PR implements the new interfaces to the dawn headers due to the refactoring [here](https://github.com/C2SM/icon-exclaim/pull/122) .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants