Skip to content

Commit

Permalink
edits following review
Browse files Browse the repository at this point in the history
  • Loading branch information
nfarabullini committed Jan 16, 2025
1 parent 48812b3 commit 33e5027
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
class TestComputePpmAllFaceValues(helpers.StencilTest):
PROGRAM = compute_ppm_all_face_values
OUTPUTS = ("p_face",)
MARKERS = (pytest.mark.levels_plus_one,)
MARKERS = (pytest.mark.requires_concat_where,)

@staticmethod
def reference(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
class TestComputeHorizontalGradientOfExnerPressureForMultipleLevels(StencilTest):
PROGRAM = compute_horizontal_gradient_of_exner_pressure_for_multiple_levels
OUTPUTS = ("z_gradh_exner",)
MARKERS = (pytest.mark.embedded_as_offset_error, pytest.mark.gtfn_miss_neighbors)
MARKERS = (pytest.mark.uses_as_offset, pytest.mark.gtfn_miss_neighbors)

@staticmethod
def reference(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
class TestComputeHydrostaticCorrectionTerm(StencilTest):
OUTPUTS = ("z_hydro_corr",)
PROGRAM = compute_hydrostatic_correction_term
MARKERS = (pytest.mark.embedded_as_offset_error, pytest.mark.gtfn_miss_neighbors)
MARKERS = (pytest.mark.uses_as_offset, pytest.mark.gtfn_miss_neighbors)

@staticmethod
def reference(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class TestFusedVelocityAdvectionStencil8To13(StencilTest):
"w_concorr_c",
"z_w_con_c",
)
MARKERS = (pytest.mark.levels_plus_one,)
MARKERS = (pytest.mark.requires_concat_where,)

@staticmethod
def reference(
Expand Down
6 changes: 4 additions & 2 deletions model/testing/src/icon4py/model/testing/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,10 @@ def _match_marker(marker, backend):
pytest.xfail("Embedded backend currently fails in remap function.")
case "uses_as_offset" if is_embedded(backend):
pytest.xfail("Embedded backend does not support as_offset.")
case "levels_plus_one" if is_embedded(backend):
pytest.xfail("Embedded backend does not support larger boundaries than field sizes.")
case "requires_concat_where" if is_embedded(backend):
pytest.xfail(
"Embedded backend does not support larger boundaries than field sizes."
)
case "domain_dims_mismatch" if is_embedded(backend):
pytest.xfail("Stencil does not support missing neighbors.")
case "gtfn_miss_neighbors" if backend and ("gtfn" in backend.name):
Expand Down

0 comments on commit 33e5027

Please sign in to comment.