Change AddLiquidity default min lock time #107 #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You were right to use the process.env value instead of the hardcoded value in initialState @BytePhoenixCoding #107 I changed the code to get the daysToLock value from the environment. You can set the DAYS_TO_LOCK environment variable to the desired value, and the code will use that value instead of the hardcoded default. Note that this will only work if the environment variable is set before the code is executed. You can set environment variables using the process.env object, like this: process.env.DAYS_TO_LOCK = 7; Alternatively, we can use a library like 'dotenv' to load environment variables from a file. This can be useful since we have many environment variables to set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You were right to use the
process.envvalue instead of the hardcoded value ininitialState@BytePhoenixCoding #107I changed the code to get the
daysToLockvalue from the environment.You can set the
DAYS_TO_LOCKenvironment variable to the desired value, and the code will use that value instead of the hardcoded default.Note that this will only work if the environment variable is set before the code is executed. You can set environment variables using the
process.envobject, like this:process.env.DAYS_TO_LOCK = 7;Alternatively, we can use a library like
dotenvto load environment variables from a file. This can be useful since we have many environment variables to set.