BQ27441 Implementation and other improvements #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bykowskiolaf
commented
Feb 3, 2025
•
- Added bq27441 support
- Refactored sensor and peripheral apis to add status codes and get rid of magic numbers
…odes and add battery level reading to LoraWAN packet
…data representation
…better maintainability
mwolosewicz
approved these changes
Feb 5, 2025
| LoRaWANHandler::LoRaWANHandler() { | ||
| Sensor<buzzverse_v1_BQ27441Data>* LoRaWANHandler::battery_sensor = nullptr; | ||
|
|
||
| LoRaWANHandler::LoRaWANHandler(Sensor<buzzverse_v1_BQ27441Data>& battery_sensor) { |
There was a problem hiding this comment.
It's better to use initializer list:
Suggested change
| LoRaWANHandler::LoRaWANHandler(Sensor<buzzverse_v1_BQ27441Data>& battery_sensor) { | |
| LoRaWANHandler::LoRaWANHandler(Sensor<buzzverse_v1_BQ27441Data>& sensor) | |
| : battery_sensor(&sensor) |
| @@ -7,15 +7,44 @@ constexpr size_t PERIPHERAL_NAME_SIZE = 32; | |||
|
|
|||
| class Peripheral { | |||
There was a problem hiding this comment.
It's a very general name - I suggest to introduce namespaces everywhere ex. namespace Buzzverse { } But it's not crucial right now.
| #include "buzzverse/bq27441.pb.h" | ||
| #include "sensor.hpp" | ||
|
|
||
| class BQ27441 : public Sensor<buzzverse_v1_BQ27441Data> { |
There was a problem hiding this comment.
I don't like buzzverse_v1_ maybe use namespace for that instead?
| Status read_data(buzzverse_v1_BQ27441Data* data) const override; | ||
|
|
||
| private: | ||
| const device* bq27441_dev; |
There was a problem hiding this comment.
Avoid keeping naked pointers. It's a general advice for whole code not only here. Try to use references if possible or some smart pointers instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.