Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue and Nuxt - live previewing data models #3919

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

uttej-vsk
Copy link
Contributor

@uttej-vsk uttej-vsk commented Feb 18, 2025

Description

This is similar to previous other PRs on adding live previewing data models that focused on live previewing the data model. It has Nuxt and Vue 3 examples for Live preview.

@samijaber One more today and a few more to come; please review it :D

Copy link

changeset-bot bot commented Feb 18, 2025

⚠️ No Changeset found

Latest commit: 9b56d9d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

gitguardian bot commented Feb 18, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11707119 Triggered Generic High Entropy Secret f5073b6 packages/sdks/snippets/vue/src/views/LivePreview.vue View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

nx-cloud bot commented Feb 18, 2025

View your CI Pipeline Execution ↗ for commit 9b56d9d.

Command Status Duration Result
nx test @snippet/react ❌ Failed 2m 27s View ↗
nx test @e2e/qwik-city ✅ Succeeded 7m 38s View ↗
nx test @e2e/nextjs-sdk-next-app ✅ Succeeded 7m 33s View ↗
nx test @e2e/nuxt ✅ Succeeded 6m 50s View ↗
nx test @e2e/angular-16 ✅ Succeeded 6m 11s View ↗
nx test @e2e/angular-16-ssr ✅ Succeeded 6m 16s View ↗
nx test @e2e/gen1-remix ✅ Succeeded 6m 4s View ↗
nx test @e2e/react-sdk-next-15-app ✅ Succeeded 5m 31s View ↗
Additional runs (36) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-02-21 21:53:14 UTC

@uttej-vsk uttej-vsk requested a review from samijaber February 18, 2025 22:15
Copy link
Contributor

@samijaber samijaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could go over the feedback in #3915: I believe all of it can be applied here as well.

@uttej-vsk
Copy link
Contributor Author

If you could go over the feedback in #3915: I believe all of it can be applied here as well.

I tried doing it for Vue as well. Along with angular.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants