Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[remix][gen2]: add remix gen2 snippets #3910

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

murrayadam
Copy link

  • Add new React Router (Remix v3) page snippet.
  • Integrate into CI for testing

https://builder-io.atlassian.net/browse/ENG-8343

Copy link

changeset-bot bot commented Feb 12, 2025

⚠️ No Changeset found

Latest commit: 85d7922

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

gitguardian bot commented Feb 12, 2025

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Contributor

@samijaber samijaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you're missing running yarn to install and update the monorepo

@murrayadam
Copy link
Author

@samijaber I just committed the updated yarn.lock.

Copy link

nx-cloud bot commented Feb 12, 2025

View your CI Pipeline Execution ↗ for commit 85d7922.

Command Status Duration Result
nx test @e2e/react-sdk-next-pages ❌ Failed 5m 38s View ↗
nx test @snippet/react-sdk-next-pages ❌ Failed 2m 50s View ↗
nx test @snippet/remix ❌ Failed 2m 2s View ↗
nx test @snippet/react-native-74 ❌ Failed 2m 32s View ↗
nx test @e2e/react-native-76-fabric ❌ Failed 2m 29s View ↗
nx test @e2e/react-native-74 ❌ Failed 2m 20s View ↗
nx test @e2e/nextjs-sdk-next-app ✅ Succeeded 8m 51s View ↗
nx test @e2e/qwik-city ✅ Succeeded 8m 42s View ↗
Additional runs (35) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-02-12 21:10:12 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants