fix: crash when guid can't be parsed (#55)

bin/index.ts

@@ -1,5 +1,5 @@
 #! /usr/bin/env node
-import { ApiClient, BugSplatApiClient, OAuthClientCredentialsClient, SymbolFile, UploadableFile, VersionsApiClient } from '@bugsplat/js-api-client';
+import { ApiClient, BugSplatApiClient, OAuthClientCredentialsClient, SymbolFile, VersionsApiClient } from '@bugsplat/js-api-client';
 import commandLineArgs, { CommandLineOptions } from 'command-line-args';
 import commandLineUsage from 'command-line-usage';
 import firstline from 'firstline';
@@ -8,9 +8,9 @@ import { mkdir, readFile, rm, stat } from 'fs/promises';
 import glob from 'glob-promise';
 import { basename, dirname, extname, join, relative } from 'path';
 import { CommandLineDefinition, argDefinitions, maxParallelThreads, usageDefinitions } from './command-line-definitions';
+import { tryGetPdbGuid, tryGetPeGuid } from './pdb';
 import { createWorkersFromSymbolFiles } from './worker';
 import { Zip } from './zip';
-import { PdbFile, PeFile } from 'pdb-guid';
 
 const currentDirectory = process ? process.cwd() : __dirname;
 const tmpDir = join(currentDirectory, 'tmp');
@@ -152,13 +152,11 @@ async function createSymbolFile(directory: string, symbolFilePath: string): Prom
     let dbgId = '';
 
     if (isPdbFile) {
-        const pdbFile = await PdbFile.createFromFile(symbolFilePath);
-        dbgId = `${pdbFile.guid}`;
+        dbgId = await tryGetPdbGuid(symbolFilePath);
     }
 
     if (isPeFile) {
-        const peFile = await PeFile.createFromFile(symbolFilePath);
-        dbgId = `${peFile.guid}`;
+        dbgId = await tryGetPeGuid(symbolFilePath);
     }
 
     if (isSymFile) {

bin/pdb.ts

@@ -0,0 +1,23 @@
+import { PdbFile, PeFile } from 'pdb-guid';
+
+export async function tryGetPdbGuid(pdbFilePath: string): Promise<string> {
+    try {
+        const pdbFile = await PdbFile.createFromFile(pdbFilePath);
+        return `${pdbFile.guid}`;
+    } catch (error) {
+        console.log(`Could not get guid for ${pdbFilePath}...`);
+    }
+
+    return '';
+}
+
+export async function tryGetPeGuid(peFilePath: string): Promise<string> {
+    try {
+        const pdbFile = await PeFile.createFromFile(peFilePath);
+        return `${pdbFile.guid}`;
+    } catch (error) {
+        console.log(`Could not get guid for ${peFilePath}...`);
+    }
+
+    return '';
+}

spec/pdb.spec.ts

@@ -0,0 +1,23 @@
+import { tryGetPdbGuid, tryGetPeGuid } from '../bin/pdb';
+
+describe('pdb', () => {
+    describe('tryGetPdbGuid', () => {
+        it('should return guid for c++ pdb', async () => {
+            return expectAsync(tryGetPdbGuid('spec/support/bugsplat.pdb')).toBeResolvedTo('E546B55B6D214E86871B40AC35CD0D461');
+        });
+
+        it('should return empty guid for unrecognized pdb', () => {
+            return expectAsync(tryGetPdbGuid('spec/support/portable.pdb')).toBeResolvedTo('');
+        });
+    });
+
+    describe('tryGetPeGuid', () => {
+        it('should return guid for c++ exe', () => {
+            return expectAsync(tryGetPeGuid('spec/support/bssndrpt.exe')).toBeResolvedTo('64FB82D565000');
+        });
+
+        it('should return empty guid for unrecognized pe file', () => {
+            return expectAsync(tryGetPeGuid('spec/support/corrupt.exe')).toBeResolvedTo('');
+        });
+    });
+});

spec/support/corrupt.exe

@@ -0,0 +1 @@
+not an exe!