Add support for an openid provider #243
Conversation
| @@ -68,12 +68,18 @@ const router = new Router({ | |||
| ], | |||
| }); | |||
|
|
|||
| const urlParams = new URLSearchParams(window.location.search); | |||
|
|
|||
| if (urlParams.has('authenticated')) { | |||
There was a problem hiding this comment.
This is simply to tell the system we should be authenticated and it'll check.
If this is used illegitimately it will have no impact and you will be sent to the login page.
There was a problem hiding this comment.
FYI
I removed this before the merge because the vue3 front-end no longer uses Vue.$storage.set('authenticated', true) to track authentication. I'm going to replace it with something similar that matches the new version of the front-end.
|
Thanks for your contribution Indy 👍🏻 It will take me some time to review/merge it as I've never used Socialite (I will have to delve into its doc) and I'm currently working on migrating to Vue v3 with significant changes to the front-end architecture. Do you plan to add some tests? (If relevant) |
|
That is no problem whatsoever, take your time! In this case tests will be difficult to make as it would need a functioning OpenID Provider and correct tokens to get data from these OpenID providers. The return token is invalidated after use thus a new token would have to be obtained from the Provider every test. In a nutshell Socialite wraps many external Login providers to work in the redirect -> callback flow and format the user information in a uniform way so we can use https://github.com/Bubka/2FAuth/pull/243/files#diff-b92ae0dfa3532466a67de136444c1c07ef4fd207e222ea28f6680b367242f747R27 No matter what provider is used, be it Steam, Google, Facebook, Authentik (My usecase) |
This paves the way for SSO without proxy authentication by using socialite with a custom class for basic openid support.
Currently we're only using and registering our own openid class.
However it has been built that other providers can be easily added in the future as it uses socialite as it's base.
Which comes with quite a few drivers built in, and more community made ones are available https://socialiteproviders.com/