Vendor.js throws error making frontend unusable

[RichyHBM]

Version

4.2.x

Details & Steps to reproduce

Having a fully working 4.1.0 setup, upgrade to one of the 4.2.x versions.

I am using Docker with traefik as a reverse proxy and Authelia to provide authentication

Expectation

Latest version works correctly

Error & Logs

vendor.js?id=3f260a606d7ce1f763fd2c9a4ddd334e:1 RangeError: Maximum call stack size exceeded
    at G._t (vendor.js?id=3f260a606d7ce1f763fd2c9a4ddd334e:2:24618)
    at G.t (vendor.js?id=3f260a606d7ce1f763fd2c9a4ddd334e:2:25383)
    at app.js?id=f732c44e609c29cc8eb65402d08d31f8:2:656661
    at v (vendor.js?id=3f260a606d7ce1f763fd2c9a4ddd334e:2:51437)
    at r (vendor.js?id=3f260a606d7ce1f763fd2c9a4ddd334e:2:48069)
    at $t (vendor.js?id=3f260a606d7ce1f763fd2c9a4ddd334e:2:48106)
    at Lt.confirmTransition (vendor.js?id=3f260a606d7ce1f763fd2c9a4ddd334e:2:51827)
    at Lt.transitionTo (vendor.js?id=3f260a606d7ce1f763fd2c9a4ddd334e:2:50154)
    at e.push (vendor.js?id=3f260a606d7ce1f763fd2c9a4ddd334e:2:53210)
    at vendor.js?id=3f260a606d7ce1f763fd2c9a4ddd334e:2:51794
s @ vendor.js?id=3f260a606d7ce1f763fd2c9a4ddd334e:1

The app.js exception is from document.title = e.meta.title = br.app.$options.i18n.t("titles." + e.name),

### Execution environment

Date: Sat, 16 Sep 2023 10:35:18 +0000
userAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/117.0.0.0 Safari/537.36
Version: 4.2.1
Environment: local
Install path: /
Debug: false
Cache driver: file
Log channel: daily
Log level:
DB driver: sqlite
PHP version: 8.1.22
Operating system: Linux
interface: fpm-fcgi
Auth guard: reverse-proxy-guard
Auth proxy logout url:
Auth proxy header for user: HTTP_REMOTE_USER
Auth proxy header for email: HTTP_REMOTE_EMAIL
webauthn user verification: preferred
Trusted proxies: none

### Containerization

- [X] Docker

### Additional information

_No response_

[Bubka]

Hi,

Does ctrl + F5 fix the issue?

[Bubka]

What language do you use?

[RichyHBM]

Hi, yes I tried doing a full clear cache and tried various browsers and different computers, and even on my phone, all using Brave though.

I don't think I've set any language in the settings so imagine just English

[Bubka]

Ok, I just pushed a commit that rolls back 969367e, that should fix the issue.

[RichyHBM]

Unfortunately this didn't seem to fix it. However I disabled the proxy authentication and reverted to user password and that seems to be fine

[Bubka]

That should have nothing to do with the proxy auth 🤨
Does the issue recur if you re-enable the proxy auth?

[RichyHBM]

It does, yes

[RichyHBM]

Has anything changed with proxy with since 4.1? As it worked fine there but seems like it's not logging me in properly in 4.2

[Bubka]

Not directly.
I was able to reproduce the issue, this is indeed triggered when the proxy authentication is On, I think it is a side effect of another change. I'm working on it.

[Bubka]

I just pushed a new fix on the dev branch (2fauth/2fauth:dev). Can you test it?

[RichyHBM]

Looks like I'm getting the same issue on dev

[Bubka]

You still have a js exception of type RangeError: Maximum call stack size exceeded !?

[RichyHBM]

I did, yea. Saying that I didn't do a full cache clear, let me try that

[RichyHBM]

Hmm yes, tried it in incognito and same issue

[Bubka]

How do you do the full cache clear?

Because I had a really weird issue on my dev env these days and despite a disabled cache and the use of ctrl+F5 I couldn't have my front-end working correctly. The only way I found to fix it was to click the 🔒 icon in the address bar (I'm using Firefox) and use the Clear cookies and site data feature.

[RichyHBM]

I chrome based browsers, I open the dev tools, then can hold the refresh button and then there is a drop-down with hard refresh+empty cache. But I've also tried in incognito

[peterbuga]

can confirm, the problem persists. same setup, traefik w/ header auth Remote-User

[Bubka]

I just pushed a new fix on the dev branch (2fauth/2fauth:dev). Can you test it?

Sorry for the late response. I just pushed a missing commit on Dev which rebuild js assets, this should fix the issue this time. Can you confirm please.

[RichyHBM]

That looks to have fixed it

[RichyHBM]

Not sure how big of a trouble it could be but may be worth moving the asset rebuild as a part of the docker build, that way you don't have to remember to do it manually

[Bubka]

Not sure how big of a trouble it could be but may be worth moving the asset rebuild as a part of the docker build, that way you don't have to remember to do it manually

You're right. It's in my (way too long) todo list by the way.
For now v4.2.3 has just been release, with the bug fix 😅