Skip to content

Commit 663eb95

Browse files
authored
ci: make it easier to see breaking change that fails ci job (lancedb#2869)
Forgot to increment the version in lancedb#2829
1 parent f0fc411 commit 663eb95

File tree

4 files changed

+29
-22
lines changed

4 files changed

+29
-22
lines changed

.github/workflows/pr-title.yml

+2-3
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,11 @@ jobs:
4141
- uses: actions/setup-python@v5
4242
with:
4343
python-version: "3.12"
44+
- run: pip install PyGithub
4445
- env:
4546
PR_NUMBER: ${{ github.event.pull_request.number }}
4647
working-directory: pr
47-
run: |
48-
pip install PyGithub
49-
python ../base/ci/check_versions.py
48+
run: python ../base/ci/check_versions.py
5049
commitlint:
5150
permissions:
5251
pull-requests: write

Cargo.toml

+16-16
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ exclude = ["python"]
2121
resolver = "2"
2222

2323
[workspace.package]
24-
version = "0.17.1"
24+
version = "0.18.0"
2525
edition = "2021"
2626
authors = ["Lance Devs <dev@lancedb.com>"]
2727
license = "Apache-2.0"
@@ -44,20 +44,20 @@ categories = [
4444
rust-version = "1.78"
4545

4646
[workspace.dependencies]
47-
lance = { version = "=0.17.1", path = "./rust/lance" }
48-
lance-arrow = { version = "=0.17.1", path = "./rust/lance-arrow" }
49-
lance-core = { version = "=0.17.1", path = "./rust/lance-core" }
50-
lance-datafusion = { version = "=0.17.1", path = "./rust/lance-datafusion" }
51-
lance-datagen = { version = "=0.17.1", path = "./rust/lance-datagen" }
52-
lance-encoding = { version = "=0.17.1", path = "./rust/lance-encoding" }
53-
lance-encoding-datafusion = { version = "=0.17.1", path = "./rust/lance-encoding-datafusion" }
54-
lance-file = { version = "=0.17.1", path = "./rust/lance-file" }
55-
lance-index = { version = "=0.17.1", path = "./rust/lance-index" }
56-
lance-io = { version = "=0.17.1", path = "./rust/lance-io" }
57-
lance-linalg = { version = "=0.17.1", path = "./rust/lance-linalg" }
58-
lance-table = { version = "=0.17.1", path = "./rust/lance-table" }
59-
lance-test-macros = { version = "=0.17.1", path = "./rust/lance-test-macros" }
60-
lance-testing = { version = "=0.17.1", path = "./rust/lance-testing" }
47+
lance = { version = "=0.18.0", path = "./rust/lance" }
48+
lance-arrow = { version = "=0.18.0", path = "./rust/lance-arrow" }
49+
lance-core = { version = "=0.18.0", path = "./rust/lance-core" }
50+
lance-datafusion = { version = "=0.18.0", path = "./rust/lance-datafusion" }
51+
lance-datagen = { version = "=0.18.0", path = "./rust/lance-datagen" }
52+
lance-encoding = { version = "=0.18.0", path = "./rust/lance-encoding" }
53+
lance-encoding-datafusion = { version = "=0.18.0", path = "./rust/lance-encoding-datafusion" }
54+
lance-file = { version = "=0.18.0", path = "./rust/lance-file" }
55+
lance-index = { version = "=0.18.0", path = "./rust/lance-index" }
56+
lance-io = { version = "=0.18.0", path = "./rust/lance-io" }
57+
lance-linalg = { version = "=0.18.0", path = "./rust/lance-linalg" }
58+
lance-table = { version = "=0.18.0", path = "./rust/lance-table" }
59+
lance-test-macros = { version = "=0.18.0", path = "./rust/lance-test-macros" }
60+
lance-testing = { version = "=0.18.0", path = "./rust/lance-testing" }
6161
approx = "0.5.1"
6262
# Note that this one does not include pyarrow
6363
arrow = { version = "52.2", optional = false, features = ["prettyprint"] }
@@ -110,7 +110,7 @@ datafusion-physical-expr = { version = "40.0", features = [
110110
] }
111111
deepsize = "0.2.0"
112112
either = "1.0"
113-
fsst = { version = "=0.17.1", path = "./rust/lance-encoding/compression-algo/fsst" }
113+
fsst = { version = "=0.18.0", path = "./rust/lance-encoding/compression-algo/fsst" }
114114
futures = "0.3"
115115
http = "0.2.9"
116116
hyperloglogplus = { version = "0.4.1", features = ["const-loop"] }

ci/check_versions.py

+10-2
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,16 @@ def parse_version(version: str) -> tuple[int, int, int]:
4747
# Check for a breaking-change label in the PRs between the last release and the current commit.
4848
commits = repo.compare(latest_release.tag_name, os.environ["GITHUB_SHA"]).commits
4949
prs = (pr for commit in commits for pr in commit.get_pulls())
50-
pr_labels = (label.name for pr in prs for label in pr.labels)
51-
has_breaking_changes = any(label == "breaking-change" for label in pr_labels)
50+
has_breaking_changes = False
51+
for pr in prs:
52+
pr_labels = (label.name for label in pr.labels)
53+
if any(label == "breaking-change" for label in pr_labels):
54+
has_breaking_changes = True
55+
print(f"Found breaking change in PR #{pr.number}: {pr.title}")
56+
print(f" {pr.html_url}")
57+
break
58+
else:
59+
print("No breaking changes found.")
5260

5361
if os.environ.get("PR_NUMBER"):
5462
# If we're running on a PR, we should validate that the version has been

python/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "pylance"
3-
version = "0.17.1"
3+
version = "0.18.0"
44
edition = "2021"
55
authors = ["Lance Devs <dev@lancedb.com>"]
66
rust-version = "1.65"

0 commit comments

Comments
 (0)