Output exact Cigar JSON parse error #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, thanks for this! I'll check out the build failures when I get chance this weekend, they're not something you've caused - the whole thing has issues it seems (I haven't touched this project in a while) |
|
@mbrodala I've fixed the test issues so if you pull in |
Also avoid the term ".cigar.json" which is misleading if a custom file is used.
|
Thanks, did that now. All green. 💚 |
|
@Brunty Is there something left to do here aside from merge? |
|
@Brunty Any update? |
|
Hey sorry for the delay! I'll get a new release tagged shortly :) Thanks for the work! |
Brunty
pushed a commit
that referenced
this pull request
Sep 19, 2023
Also avoid the term ".cigar.json" which is misleading if a custom file is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also avoid the term ".cigar.json" which is misleading if a custom file is used.