Feature/set target permissions #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now supporting a writableDirectories configuration option to indicate which directories should be writable by the web server.
…deployment-commands Add generic post deployment commands
- Now supporting a writableDirectories configuration option to indicate which directories should be writable by the web server.
…ersity/laravel-vm-deployment-action into feature/set-target-permissions # Conflicts: # README.md # dist/index.js # index.js
christopher-keith
requested changes
Feb 21, 2020
- Now using parseArrayFromPipeDelimitedString(), eliminating need for truthy test.
christopher-keith
approved these changes
Feb 24, 2020
| options, | ||
| `stat ${path}/${dir} >/dev/null && chmod -R 775 ${path}/${dir}` | ||
| ); | ||
| } |
There was a problem hiding this comment.
There should be a /* eslint-enabled no-restricted-syntax */ after the for
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does introduce a potentially breaking change with Laravel, since it no longer processes the
storagedirectory unless it's listed in the appropriate configuration option. Based on the description of #11, maybe that's okay if existing apps are already not using the internal storage directory?resolves #13, #11