Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(actions/plan): add argument to suppress PR comments. #26

Merged
merged 9 commits into from
Sep 8, 2022

Conversation

neverendingqs
Copy link
Member

The plan is available in the job summary (#18). Thoughts on adding an arg to suppress PR comments?

@neverendingqs neverendingqs requested review from omsmith and removed request for omsmith September 1, 2022 14:54
Copy link
Contributor

@omsmith omsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neverendingqs
Copy link
Member Author

Could you update the shared workflow as well? https://github.com/Brightspace/terraform-workflows/blob/main/.github/workflows/workflow.yml

👍. 03a385d. Will try out the action on the repo I was thinking of applying this on.

Note: I didn't investigate, but the editor was advising something was wrong with matrix:
image

Seems like editor might be the one that's wrong?

@omsmith
Copy link
Contributor

omsmith commented Sep 7, 2022

Seems like editor might be the one that's wrong?

They updated the syntax, but still allow strings - the editor is preferring the newer syntax. S'all good.

@neverendingqs neverendingqs merged commit 0aeeac3 into main Sep 8, 2022
@neverendingqs neverendingqs deleted the neverendingqs-patch-2 branch September 8, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants