Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D2L0017: Drop diagnostic. Migrated to D2L.Lms.Analyzers #949

Merged
merged 1 commit into from
Apr 25, 2024
Merged

D2L0017: Drop diagnostic. Migrated to D2L.Lms.Analyzers #949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
149 changes: 0 additions & 149 deletions src/D2L.CodeStyle.Analyzers/ApiUsage/ServiceLocator/SingletonLocatorAnalyzer.cs
View file
Open in desktop

This file was deleted.

11 changes: 1 addition & 10 deletions src/D2L.CodeStyle.Analyzers/Diagnostics.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,16 +65,7 @@ public static class Diagnostics {

// Retired:
// D2L0014 (SingletonIsntImmutable): "Classes marked as a singleton should be immutable.",

public static readonly DiagnosticDescriptor SingletonLocatorMisuse = new DiagnosticDescriptor(
id: "D2L0017",
title: "Can only use OldAndBrokenSingletonLocator to inject interfaces with the [Singleton] attribute",
messageFormat: "Cannot use OldAndBrokenSingletonLocator to inject {0} because it lacks the [Singleton] attribute",
category: "Correctness",
defaultSeverity: DiagnosticSeverity.Error,
isEnabledByDefault: true,
description: "Can only use OldAndBrokenSingletonLocator to inject interfaces with the [Singleton] attribute."
);
// D2L0017 (SingletonLocatorMisuse): "Can only use OldAndBrokenSingletonLocator to inject interfaces with the [Singleton] attribute"

public static readonly DiagnosticDescriptor DangerousMethodsShouldBeAvoided = new DiagnosticDescriptor(
id: "D2L0018",
Expand Down
101 changes: 0 additions & 101 deletions tests/D2L.CodeStyle.Analyzers.Test/Specs/SingletonLocatorAnalyzer.cs
View file
Open in desktop

This file was deleted.

Loading