Improved code quality #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trungseo:lantrungseo/mattermost-plugin-zoom into mattermostGH-154-PMI-setting-command
1. Resolved the problem of 500 internal server error which we were getting on clicking create new meeting when our use PMI was set to ask 2. Added c.apiURL in URL 3. Added auto suggestion for use PMI
…bapp/node_modules'. Stop
1. Added constants at various places
1. Added EOF 2. Added Proper comments
…mmand of zoom plugin
…ghtscout/mattermost-plugin-zoom into MI-1996
1.Improved code quality 2.Added various constants
1. Improved code quality 2. Changed few names
1. Improved code quality 2. Improved code readability 3. Resolved gramatical mistakes
1. Changed few names
1. Improved code readability 2. Removed indirect dependencies 3. Changed few names
1. Improved code quality 2. Returned json instead of text
1. Improved code quality
…ghtscout/mattermost-plugin-zoom into MI-1996
…ghtscout/mattermost-plugin-zoom into MI-1996
manojmalik20
approved these changes
Nov 14, 2022
avas27JTG
added a commit
that referenced
this pull request
Oct 27, 2023
…ces for meeting creation (mattermost#284) * [MI-1996]: To solve the bugs in PMI feature of zoom plugin and to resolve merge conflicts (#1) * add "/zoom setting usePMI" command * update from 'master' branch * save usePMI as user preference * fix error handling in /zoom usePMI setting command * update from upstream * create meeting without PMI * finish feature * fix lint * tidy go module * update tests, optimize code * tidy the go module * [MI-1996]: Resolved the bug in use PMI feature of zoom plugin 1. Resolved the problem of 500 internal server error which we were getting on clicking create new meeting when our use PMI was set to ask 2. Added c.apiURL in URL 3. Added auto suggestion for use PMI * [MI-1996]: Resolved merge conflicts * [MI-1996]: Resolved the error of make: *** No rule to make target 'webapp/node_modules'. Stop * [MI-1996]: Removed error of check-style * [MI-1996]: Resolved the error faced in golangci-lint * [MI-1996]: Review fixes done 1. Added constants at various places * [MI-1996]:Review fixes done 1. Added EOF 2. Added Proper comments * [MI-1996]:Resolved the panic that we were getting on running slash command of zoom plugin * [MI-1996]: Work in Progress * [MI-1996]:Added properly with and without PMI feature of zoom plugin * [MI-1996]: Improved code quality * [MI-1996]: Fixed CI errors * [MI-1996]:Review fixes done 1.Improved code quality 2.Added various constants * [MI-1996]: Review fixes done 1. Improved code quality 2. Changed few names * [MI-1996]:Review fixes done 1. Improved code quality 2. Improved code readability 3. Resolved gramatical mistakes * [MI-1996]: Review fixes done 1. Changed few names * [MI-1996]: Review fixes done 1. Improved code readability 2. Removed indirect dependencies 3. Changed few names * [MI-1996]: Review fixes done 1. Improved code quality 2. Returned json instead of text * Fixed CI errors * [MI-1996]:Review fixes done 1. Improved code quality Co-authored-by: lantrungseo <lantrungseo@gmail.com> * Improved code quality (#2) * add "/zoom setting usePMI" command * update from 'master' branch * save usePMI as user preference * fix error handling in /zoom usePMI setting command * update from upstream * create meeting without PMI * finish feature * fix lint * tidy go module * update tests, optimize code * tidy the go module * [MI-1996]: Resolved the bug in use PMI feature of zoom plugin 1. Resolved the problem of 500 internal server error which we were getting on clicking create new meeting when our use PMI was set to ask 2. Added c.apiURL in URL 3. Added auto suggestion for use PMI * [MI-1996]: Resolved merge conflicts * [MI-1996]: Resolved the error of make: *** No rule to make target 'webapp/node_modules'. Stop * [MI-1996]: Removed error of check-style * [MI-1996]: Resolved the error faced in golangci-lint * [MI-1996]: Review fixes done 1. Added constants at various places * [MI-1996]:Review fixes done 1. Added EOF 2. Added Proper comments * [MI-1996]:Resolved the panic that we were getting on running slash command of zoom plugin * [MI-1996]: Work in Progress * [MI-1996]:Added properly with and without PMI feature of zoom plugin * [MI-1996]: Improved code quality * [MI-1996]: Fixed CI errors * [MI-1996]:Review fixes done 1.Improved code quality 2.Added various constants * [MI-1996]: Review fixes done 1. Improved code quality 2. Changed few names * [MI-1996]:Review fixes done 1. Improved code quality 2. Improved code readability 3. Resolved gramatical mistakes * [MI-1996]: Review fixes done 1. Changed few names * [MI-1996]: Review fixes done 1. Improved code readability 2. Removed indirect dependencies 3. Changed few names * [MI-1996]: Review fixes done 1. Improved code quality 2. Returned json instead of text * Fixed CI errors * [MI-1996]:Review fixes done 1. Improved code quality * [MI-1996]: Improved code quality Co-authored-by: lantrungseo <lantrungseo@gmail.com> * Done the Review fixes of a PR mattermost#284 (#3) * add "/zoom setting usePMI" command * update from 'master' branch * save usePMI as user preference * fix error handling in /zoom usePMI setting command * update from upstream * create meeting without PMI * finish feature * fix lint * tidy go module * update tests, optimize code * tidy the go module * [MI-1996]: Resolved the bug in use PMI feature of zoom plugin 1. Resolved the problem of 500 internal server error which we were getting on clicking create new meeting when our use PMI was set to ask 2. Added c.apiURL in URL 3. Added auto suggestion for use PMI * [MI-1996]: Resolved merge conflicts * [MI-1996]: Resolved the error of make: *** No rule to make target 'webapp/node_modules'. Stop * [MI-1996]: Removed error of check-style * [MI-1996]: Resolved the error faced in golangci-lint * [MI-1996]: Review fixes done 1. Added constants at various places * [MI-1996]:Review fixes done 1. Added EOF 2. Added Proper comments * [MI-1996]:Resolved the panic that we were getting on running slash command of zoom plugin * [MI-1996]: Work in Progress * [MI-1996]:Added properly with and without PMI feature of zoom plugin * [MI-1996]: Improved code quality * [MI-1996]: Fixed CI errors * [MI-1996]:Review fixes done 1.Improved code quality 2.Added various constants * [MI-1996]: Review fixes done 1. Improved code quality 2. Changed few names * [MI-1996]:Review fixes done 1. Improved code quality 2. Improved code readability 3. Resolved gramatical mistakes * [MI-1996]: Review fixes done 1. Changed few names * [MI-1996]: Review fixes done 1. Improved code readability 2. Removed indirect dependencies 3. Changed few names * [MI-1996]: Review fixes done 1. Improved code quality 2. Returned json instead of text * Fixed CI errors * [MI-1996]:Review fixes done 1. Improved code quality * [MI-1996]: Improved code quality * [MI-1996]:Done the review fixes of a PR mattermost#284 1. Improved code quality 2. Changed the names of few constants * [MI-1996]: Review fixes done 1. Changed few names * [MI-1996]: Review fixes done 1. Modified error * [MI-1996]: Review fixes done 1. Changed default topic to topic * [MI-1996]: Review fixes done 1. Improved code quality Co-authored-by: lantrungseo <lantrungseo@gmail.com> * Review fixes done 1.Improved code readability * [MI-2571]: Done the review fixes of PR: mattermost#284 (#4) * [MI-2571]: Review fixes done 1. Improved code quality and readability * [MI-2571]: Review fixes done 1.Improved code quality * [MI-2571]: Review fixes done 1. Changed status code * [MI-2571]: Review fixes done 1. Improved code quality 2. Changed few names of variables and functions * [MI-2571]: Review fixes done 1. Improved code quality * [MI-3656]: Fixed test case. * [mattermostGH-154]: Added logic to remove remove action buttons once user has selected an option for PMI setting. * [mattermostGH-154]: Fixed zoom video icon. * [mattermostGH-154]: Added original zoom video button styles. --------- Co-authored-by: lantrungseo <lantrungseo@gmail.com> Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com> Co-authored-by: Abhishek Verma <72438220+avas27JTG@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.