Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3377 Added a check for sp_MSgetalertinfo #3381

Conversation

Montro1981
Copy link
Contributor

@Montro1981 Montro1981 commented Oct 11, 2023

Fixes #3377
Added a permission check for sp_MSgetalertinfo.
The change is similar to PR #3359 for the Invalid Logins, did change the @AlertInfo table to a temp table #AlertInfo and added it to the clean up steps.

@BrentOzar
Copy link
Member

@Montro1981 can you resolve the conflicts between this and your other changes first? Sorry about that.

@Montro1981
Copy link
Contributor Author

@BrentOzar Will look at it tomorrow (European time)

@Montro1981
Copy link
Contributor Author

Montro1981 commented Dec 15, 2023

@BrentOzar
Conflict resolved, tested the deployment and EXEC [dbo].[sp_Blitz] @CheckUserDatabaseObjects = 1 didn't throw any errors.

My name is Martin. You commented on it on Twitch last night. I couldn't watch it live sadly.

Copy link
Member

@BrentOzar BrentOzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the modified pull request! Looks good, works on my machine, heh. Merging into dev, will be in the next release with credit to you in the release notes.

@BrentOzar BrentOzar merged commit f2b7a80 into BrentOzarULTD:dev Jan 10, 2024
@BrentOzar BrentOzar added this to the 2024-03 Release milestone Jan 10, 2024
@Montro1981 Montro1981 deleted the SQL-Server-First-Responder-Kit_3377-sp_MSgetalertinfo branch March 28, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sp_Blitz] [Bug] Permissions checks are not working as intended
2 participants