Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-2487] Reverted minimum sdk version change #1224

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

nsingh-branch
Copy link
Contributor

Reference

SDK-SDK -- Reverted minimum sdk version change

Description

Changed the minimum SDK from 23 back to 21 since some clients may not want to upgrade this value in their app yet.

Original PR: #1213

Testing Instructions

Ensure the SDK still builds and integrates properly and all of the SDK's features still function.

Risk Assessment [LOW]

  • I, the PR creator, have tested — integration, unit, or otherwise — this code.

Reviewer Checklist (To be checked off by the reviewer only)

  • JIRA Ticket is referenced in PR title.
  • Correctness & Style
    • Conforms to AOSP Style Guides
    • Mission critical pieces are documented in code and out of code as needed.
  • Unit Tests reviewed and test issue sufficiently.
  • Functionality was reviewed in QA independently by another engineer on the team.

cc @BranchMetrics/saas-sdk-devs for visibility.

@gdeluna-branch
Copy link
Contributor

Does that PR need to be reverted? Does the tool work with this sdk ver?

@nsingh-branch
Copy link
Contributor Author

Does that PR need to be reverted? Does the tool work with this sdk ver?

@gdeluna-branch I just tested out Nix and it appears to still be working fine, so the version bump may not be necessary. I've also reached out to allen for confirmation too though.

@nsingh-branch nsingh-branch merged commit 2b798cd into master Oct 1, 2024
4 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants