Convert the type of a specific column in a csv file. #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3c61cff to
88e8bf9
Compare
nissy0409240
commented
Jul 16, 2024
| @@ -40,6 +40,7 @@ python-gnupg = "==0.4.8" | |||
| openpyxl = "==3.0.9" | |||
| pyminizip = "==0.2.5" | |||
| psycopg2 = "==2.9.1" | |||
| numpy = "<2" | |||
There was a problem hiding this comment.
Fixed several tests that would fail if the numpy version was not fixed.
cliboa/scenario/transform/csv.py
Outdated
| if self._type == "int": | ||
| # When reading from csv, the following error occurs: | ||
| # ValueError: invalid literal for int() with base 10 | ||
| # To avoid this, convert to float and then convert to int |
There was a problem hiding this comment.
型変換が失敗した場合の挙動を定義してください。
There was a problem hiding this comment.
ご確認ありがとうございます
定義しました
cliboa/scenario/transform/csv.py
Outdated
| @@ -285,6 +285,68 @@ def _read_csv_func(self, chunksize, fi, fo): | |||
| first_write = False | |||
|
|
|||
|
|
|||
| class CsvColumnTypeConvert(FileBaseTransform): | |||
There was a problem hiding this comment.
カラムを加工するわけではないので、classの名前はCsvTypeConvertでいかがでしょうか。
There was a problem hiding this comment.
ご確認ありがとうございます
対応しました
yasuhiro-ohba
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief
Convert the type of a specific column in a csv file.
Points to Check
Test
Confirmed
Review Limit
As soon as possible.