[WEB-9515] Send comp to CompPlex before Webapp #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release urls still need to be updated
JustWalters
commented
Nov 28, 2023
…d-comps-to-comp-plex
I'm not yet sure what to pass to BoweryService.addUnitComp
mlwatkins
approved these changes
Dec 1, 2023
| unitType: unitCompData.unitLayout ? camelCase(unitCompData.unitLayout) : null, | ||
| unitSquareFootage: unitCompData.sqft, | ||
| }, | ||
| resourceInformation: { |
There was a problem hiding this comment.
Do we have property information here?
There was a problem hiding this comment.
Nope. We don't capture a lot of info right now.
lsklyut
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bowery.atlassian.net/browse/WEB-9515
Still needs some UX massaging, though may come in a separate PR.
This will not work if https://github.com/Bowery-RES/comp-plex/pull/713 has not been deployed. We can make the extension more resilient if we think that's too much of a problem. It will work without https://github.com/Bowery-RES/Webapp/pull/9162.