-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom LaTeX delimiters to preferences #1221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the commented place. 🙏
And, is yarn.lock
necessary? Please delete it if you do not need it. 👍
browser/lib/markdown.js
Outdated
|
||
// FIXME We should not depend on global variable. | ||
const katex = window.katex | ||
var config = ConfigManager.get() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use const
instead of var
.
In a modern browser, please use let
or const
.
The bug was fixed. That was only my mistake of property names. |
Thanks for your fixing! 👍 |
There are something to note.
|
See #1201. This add optional LaTeX delimiters.
However, currently this has a bug that LaTeX preference value seems not to be saved but I cannot understand. I want help to solve.