Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added the context menu to the list view #1036

Merged
merged 1 commit into from
Oct 30, 2017
Merged

added the context menu to the list view #1036

merged 1 commit into from
Oct 30, 2017

Conversation

mslourens
Copy link
Contributor

Fixes #1034

I copied the code from the NoteItem context menu and added that to the SimpleItem. I couldn't find any tests for this behavior, so I left it for now.

@kazup01 kazup01 self-requested a review October 30, 2017 15:34
kazup01
kazup01 approved these changes Oct 30, 2017
View reviewed changes
Copy link
Member

@kazup01 kazup01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazup01 kazup01 merged commit 73b5546 into BoostIO:master Oct 30, 2017
@kazup01
Copy link
Member

kazup01 commented Oct 30, 2017

Merged. Thank you for your contribution @mslourens 🎉

@mslourens mslourens deleted the context-menu branch October 30, 2017 16:20
@kohei-takata kohei-takata mentioned this pull request Nov 25, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazup01 kazup01 kazup01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mslourens @kazup01 @BoostnoteBot