Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][0.6.6] Raylet connection closed & RayOutOfMemoryError #3

Merged
merged 30 commits into from
Feb 21, 2020

Conversation

Edilmo
Copy link

@Edilmo Edilmo commented Feb 7, 2020

We have been experimenting "Raylet connection closed" and "RayOutOfMemoryError" errors with Ray 0.6.6. This PR is taking advantage of the CI introduce in the #2 PR and try to alleviate those problems by cherry picking changes made after 0.6.6 that, in one way or another, deal with the errors.

After some investigation we found several Issues/PRs trying to address errors with this message as main symptom.

Our real root cause has not been identified yet. But in order to test our dev-process around Ray/RLlib, we are taking this as opportunity to experience the process of cherrypicking changes from upstream and applying that to our running Ray version.

Links:

This PR contains changes that help with memory issues
ray-project#4942
This PR contains changes that help with memory issues
ray-project#4945
This PR contains changes that help with memory issues
ray-project#4964
This PR contains changes that help with memory issues
ray-project#4586
Specifically, we are setting a
travis like ADO pipeline following
what is already present in the .travis.yml
file in the root of the repo.
@Edilmo Edilmo force-pushed the ms/fix-0.6.6-con-close branch 4 times, most recently from 2a8c36c to e78e2be Compare February 8, 2020 02:41
@Edilmo Edilmo force-pushed the ms/fix-0.6.6-con-close branch 4 times, most recently from c87ad51 to 13a5173 Compare February 8, 2020 23:26
@Edilmo Edilmo force-pushed the ms/fix-0.6.6-con-close branch from 13a5173 to 0ddcfa0 Compare February 9, 2020 16:58
This PR contains changes that help with memory issues
ray-project#4555
This PR contains changes that help with memory issues
ray-project#4533
This PR contains changes that help with memory issues
ray-project#4465
This PR contains changes that help with memory issues
ray-project#4701
This PR contains changes that help with memory issues
ray-project@d13e889
This PR contains changes that help with memory issues
ray-project@0abcd07
This PR contains changes that help with memory issues
ray-project@28d73f6
This PR contains changes that help with memory issues
ray-project#4959
@Edilmo Edilmo force-pushed the ms/fix-0.6.6-con-close branch from 2116625 to e7dbea2 Compare February 10, 2020 09:14
This PR contains changes that help with memory issues
ray-project#4615
This PR contains changes that help with memory issues
ray-project#4711
This PR contains changes that help with memory issues
ray-project#6073
This PR contains changes that help with memory issues
ray-project#4862
@Edilmo Edilmo force-pushed the ms/fix-0.6.6-con-close branch 10 times, most recently from 754e2f9 to 3d074e2 Compare February 17, 2020 21:24
@Edilmo Edilmo force-pushed the ms/fix-0.6.6-con-close branch 2 times, most recently from 310eed0 to c1c7f5d Compare February 18, 2020 04:53
@Edilmo Edilmo force-pushed the ms/fix-0.6.6-con-close branch from c1c7f5d to 33ca62b Compare February 18, 2020 07:31
@Edilmo Edilmo force-pushed the ms/fix-0.6.6-con-close branch from c04ff62 to 5cd4651 Compare February 19, 2020 08:00
@Edilmo Edilmo force-pushed the ms/fix-0.6.6-con-close branch 2 times, most recently from 2bb206b to ab05c34 Compare February 20, 2020 19:33
@Edilmo Edilmo force-pushed the ms/fix-0.6.6-con-close branch from ab05c34 to 2c264c7 Compare February 20, 2020 21:53
@Edilmo Edilmo changed the title [fix][0.6.6] Raylet connection closed [fix][0.6.6] Raylet connection closed & RayOutOfMemoryError Feb 20, 2020
Copy link
Collaborator

@RuofanKong RuofanKong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@Edilmo Edilmo merged commit 86031f1 into releases/0.6.6 Feb 21, 2020
@Edilmo Edilmo deleted the ms/fix-0.6.6-con-close branch February 21, 2020 01:29
Edilmo pushed a commit that referenced this pull request Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants