fix: make all packages internal (#17)

Packages below `pkg/` (actually any dir except `internal/`) can be used as a library by any external third-party project. By moving all packages below `internal/` we don't need to be concerned about API stability guarantees that we would need to give at one point if we left those packages public. In general I'd suggest to make all new code internal and only move it into `pkg/` if we decide to provide parts of `sops-check` as a libary with proper API stability guarantees towards the users.
Bonial-International-GmbH · Nov 29, 2024 · 7352024 · 7352024
1 parent be644ed
commit 7352024
Show file tree

Hide file tree

Showing 16 changed files with 5 additions and 5 deletions.
diff --git a/pkg/config/config.go → internal/config/config.go b/pkg/config/config.go → internal/config/config.go
diff --git a/pkg/config/config_test.go → internal/config/config_test.go b/pkg/config/config_test.go → internal/config/config_test.go
diff --git a/pkg/config/testdata/config.yaml → internal/config/testdata/config.yaml b/pkg/config/testdata/config.yaml → internal/config/testdata/config.yaml
diff --git a/internal/rules/compile.go b/internal/rules/compile.go
@@ -4,7 +4,7 @@ import (
 	"fmt"
 	"regexp"
 
-	"github.com/Bonial-International-GmbH/sops-check/pkg/config"
+	"github.com/Bonial-International-GmbH/sops-check/internal/config"
 )
 
 // Compile takes a slice of rule configurations and compiles it into a single

diff --git a/internal/rules/rules_test.go b/internal/rules/rules_test.go
@@ -8,8 +8,8 @@ import (
 	"strings"
 	"testing"
 
+	"github.com/Bonial-International-GmbH/sops-check/internal/config"
 	"github.com/Bonial-International-GmbH/sops-check/internal/rules"
-	"github.com/Bonial-International-GmbH/sops-check/pkg/config"
 	"github.com/goccy/go-yaml"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"

diff --git a/pkg/sops/sops.go → internal/sops/sops.go b/pkg/sops/sops.go → internal/sops/sops.go
diff --git a/pkg/sops/sops_test.go → internal/sops/sops_test.go b/pkg/sops/sops_test.go → internal/sops/sops_test.go
diff --git a/...data/invalid_sops_files/bad_matadata.yaml → ...data/invalid_sops_files/bad_matadata.yaml b/...data/invalid_sops_files/bad_matadata.yaml → ...data/invalid_sops_files/bad_matadata.yaml
diff --git a/...testdata/invalid_sops_files/plaintext.txt → ...testdata/invalid_sops_files/plaintext.txt b/...testdata/invalid_sops_files/plaintext.txt → ...testdata/invalid_sops_files/plaintext.txt
diff --git a/...s/testdata/valid_sops_files/encrypted.env → ...s/testdata/valid_sops_files/encrypted.env b/...s/testdata/valid_sops_files/encrypted.env → ...s/testdata/valid_sops_files/encrypted.env
diff --git a/...s/testdata/valid_sops_files/encrypted.ini → ...s/testdata/valid_sops_files/encrypted.ini b/...s/testdata/valid_sops_files/encrypted.ini → ...s/testdata/valid_sops_files/encrypted.ini
diff --git a/.../testdata/valid_sops_files/encrypted.json → .../testdata/valid_sops_files/encrypted.json b/.../testdata/valid_sops_files/encrypted.json → .../testdata/valid_sops_files/encrypted.json
diff --git a/.../testdata/valid_sops_files/encrypted.yaml → .../testdata/valid_sops_files/encrypted.yaml b/.../testdata/valid_sops_files/encrypted.yaml → .../testdata/valid_sops_files/encrypted.yaml
diff --git a/...s/testdata/valid_sops_files/encrypted.yml → ...s/testdata/valid_sops_files/encrypted.yml b/...s/testdata/valid_sops_files/encrypted.yml → ...s/testdata/valid_sops_files/encrypted.yml
diff --git a/main.go b/main.go
@@ -9,10 +9,10 @@ import (
 	"strings"
 
 	"github.com/Bonial-International-GmbH/sops-check/internal/cli"
+	"github.com/Bonial-International-GmbH/sops-check/internal/config"
 	"github.com/Bonial-International-GmbH/sops-check/internal/rules"
+	"github.com/Bonial-International-GmbH/sops-check/internal/sops"
 	"github.com/Bonial-International-GmbH/sops-check/internal/stringutils"
-	"github.com/Bonial-International-GmbH/sops-check/pkg/config"
-	"github.com/Bonial-International-GmbH/sops-check/pkg/sops"
 )
 
 func main() {

diff --git a/main_test.go b/main_test.go
@@ -6,7 +6,7 @@ import (
 	"strings"
 	"testing"
 
-	"github.com/Bonial-International-GmbH/sops-check/pkg/config"
+	"github.com/Bonial-International-GmbH/sops-check/internal/config"
 	"github.com/goccy/go-yaml"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"