Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bumpversion #180

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Remove bumpversion #180

merged 1 commit into from
Jan 15, 2025

Conversation

andrewgy8
Copy link
Collaborator

@andrewgy8 andrewgy8 commented Jan 13, 2025

I would like to remove bumpversion as a dependency as the project is questionably (un)maintained (see below) and we would need to migrate to a fork-of-the-fork of the project if we want to continue using it.

However, I question the need for it at all as we only bump the init file and our release process is quite smooth with using the release functionality on github (recently documented here).

Any thoughts on this @amureki @Bogdanp ? FYI, I see this is still a dependency on Dramatiq

Bumpversion status:

@amureki
Copy link
Collaborator

amureki commented Jan 14, 2025

Honestly, I don't think I used it in the latest releases of django_dramatiq.

However, I question the need for it at all as we only bump the init file and our release process is quite smooth with using the release functionality on github (recently documented here).

...were exactly my thoughts.

Good call, I'd agree with you 👍

@andrewgy8 andrewgy8 merged commit bab0372 into master Jan 15, 2025
14 checks passed
@andrewgy8 andrewgy8 deleted the remove-bumpversion branch January 15, 2025 11:06
m000 pushed a commit to m000/django_dramatiq that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants