Add service port name to help istio detect protocol

Bobgy · Apr 26, 2020 · faf437d · faf437d
1 parent 5076763
commit faf437d
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 8 deletions.
diff --git a/pipeline/minio/base/service.yaml b/pipeline/minio/base/service.yaml
@@ -4,7 +4,8 @@ metadata:
   name: minio-service
 spec:
   ports:
-  - port: 9000
+  - name: http
+    port: 9000
     protocol: TCP
     targetPort: 9000
   selector:

diff --git a/pipeline/mysql/base/service.yaml b/pipeline/mysql/base/service.yaml
@@ -4,4 +4,7 @@ metadata:
   name: mysql
 spec:
   ports:
-  - port: 3306
+  - name: mysql
+    port: 3306
+    protocol: TCP
+    targetPort: 3306
diff --git a/pipeline/pipelines-ui/base/service.yaml b/pipeline/pipelines-ui/base/service.yaml
@@ -7,7 +7,9 @@ metadata:
     app: ml-pipeline-ui
 spec:
   ports:
-  - port: 80
+  - name: http
+    protocol: TCP
+    port: 80
     targetPort: 3000
   selector:
     app: ml-pipeline-ui
@@ -20,7 +22,9 @@ metadata:
     app: ml-pipeline-tensorboard-ui
 spec:
   ports:
-  - port: 80
+  - name: http
+    protocol: TCP
+    port: 80
     targetPort: 3000
   selector:
     app: ml-pipeline-tensorboard-ui
diff --git a/pipeline/profile-controller/base/configmap.yaml b/pipeline/profile-controller/base/configmap.yaml
@@ -138,9 +138,12 @@ data:
                         "labels": { "app": "ml-pipeline-ui-artifact" }
                     },
                     "spec": {
-                        "ports": [
-                            { "port": 80, "targetPort": 3000 }
-                        ],
+                        "ports": [{
+                            "name": "http", # name is required to let istio understand request protocol
+                            "port": 80,
+                            "protocol": "TCP",
+                            "targetPort": 3000
+                        }],
                         "selector": { "app": "ml-pipeline-ui-artifact" }
                     }
                 },

diff --git a/pipeline/profile-controller/base/service.yaml b/pipeline/profile-controller/base/service.yaml
@@ -4,4 +4,7 @@ metadata:
   name: profile-controller
 spec:
   ports:
-  - port: 80
+  - name: http
+    port: 80
+    protocol: TCP
+    targetPort: 80