Show chunk borders #542
Merged
Show chunk borders #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work! |
|
Aw dangit, I was hoping I wouldn't have to do that myself :p |
|
I mean .. you can also wait for me to do it, but then it'll end up on the todo and probably take a while to be prioritised ^^ |
|
Fair enough... |
The hires tiles just always had the chunkborders on them. But the "fade out" distance of those models was 1000. While the fade distance of the chunkborders on lowres tiles was between 200 and 600. This would cause an uneven fadeout between the lowres tiles and the hires tiles.
|
If you move the show-chunk-borders variable away from the appState directly to the mapviewer and do it like the And then i am happy :3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should probably add a toggle for it, though.
And a way to customise the colour.