This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
[BBS-291] Migrate to GitHub Actions #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pafonta
reviewed
Feb 25, 2021
| run: tox -vv -e lint -- --color=yes | ||
|
|
||
| - name: tests and coverage | ||
| run: tox -vv -e ${{ matrix.tox-env }} -- --color=yes |
There was a problem hiding this comment.
Is matrix.tox-env able to find the tox-env values nested inside matrix.include.[*].tox-env?
There was a problem hiding this comment.
Yes! I also tried with ${{ matrix.tox-env}} but it failed—here it should be w/o brackets.
There was a problem hiding this comment.
I also tried with ${{ matrix.tox-env }} but it failed
Is there a typo? Because this is what is in the file.
jankrepl
reviewed
Feb 25, 2021
|
Hello @FrancescoCasalegno ! Thanks! Had you had a look at #258 (comment)? |
jankrepl
approved these changes
Feb 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes Jenkins and Travis CI support, adds GitHub Actions support.
Fixes BBS-291.
TODO
masterin this branch after [BBS-233] Remove Sent2Vec #247 gets mergedlint,docs,check-packagingonly if Python 3.7CONTRIBUTING.mdinfo on triggering CIChecklist:
first).
whatsnew.rstupdated (if needed).setup.pyandrequirements.txtupdated with new dependencies.[test travis]to your git commit to run it)