allow stimulus_description in ScalaNWBReader

[darshanmandge]

• To get protocol_name from stimulus_description entries to allow ecodes names other than Step
• Preserves the default protocol_name Step for Scala files
• Tested for collaborator files for hippocampus and straitum

[AurelienJaquier]

Very nice! Are we sure that the attrs will always have stimulus_description? If not, we should take this edge case into account

[darshanmandge]

Thanks @AurelienJaquier . I added a exception AttributeError with a default protocol_name Step.

[AurelienJaquier]

I think this should be KeyError

[darshanmandge]

Updated in new commit.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 73.68%. Comparing base (4bfe32a) to head (cb6f730).
Report is 6 commits behind head on master.

Files	Patch %	Lines
bluepyefe/nwbreader.py	0.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage   73.78%   73.68%   -0.11%     
==========================================
  Files          38       38              
  Lines        2415     2421       +6     
==========================================
+ Hits         1782     1784       +2     
- Misses        633      637       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AurelienJaquier]

Looks great, thanks!

[AurelienJaquier]

do you still need the update_scala branch @darshanmandge ? If not, could you delete it?

[darshanmandge]

deleted. thanks!