Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simulated values to IV and FI plots for comparison with experimental data #177

Merged
merged 10 commits into from
Nov 26, 2024

Conversation

ilkilic
Copy link
Collaborator

@ilkilic ilkilic commented Nov 15, 2024

This PR enhances IV and FI plots by adding simulated data points at regular intervals for better comparison of experimental and simulated data. These plots are only generated for rheobase type optimisations, and a warning clarifies that they will not be plotted for non-rheobase cases.

@ilkilic ilkilic self-assigned this Nov 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 25.36232% with 103 lines in your changes missing coverage. Please review.

Project coverage is 52.06%. Comparing base (8d5b0ab) to head (c75d3fc).
Report is 129 commits behind head on main.

Files with missing lines Patch % Lines
bluepyemodel/emodel_pipeline/plotting_utils.py 23.95% 73 Missing ⚠️
bluepyemodel/emodel_pipeline/plotting.py 11.76% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
- Coverage   60.07%   52.06%   -8.02%     
==========================================
  Files         109      124      +15     
  Lines        7838    10569    +2731     
==========================================
+ Hits         4709     5503     +794     
- Misses       3129     5066    +1937     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@darshanmandge darshanmandge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Will this work for non-rheobase type optimisations?

@ilkilic
Copy link
Collaborator Author

ilkilic commented Nov 25, 2024

@darshanmandge we do not support non-rheobase type optimisations for those plots. I have added a warning to clarify it

@darshanmandge
Copy link
Collaborator

Just to clarify for other users: this PR adds the additional simulated data points for comparing the experimental and simulated IV and FI curves at regular intervals of stimulus amplitudes on the x-axis.
For non-rheobase type optimisations, the curves will still be plotted to compare the experimental and simulated data but only for the amplitudes in the optimisation protocols step amplitudes. Is this correct @ilkilic? You can describe this in the PR description.

@ilkilic
Copy link
Collaborator Author

ilkilic commented Nov 25, 2024

@darshanmandge Sorry if it was not clear before, but for non-rheobase type optimisations, the plots are not generated at all. I have updated the PR description to clarify this

Copy link
Collaborator

@darshanmandge darshanmandge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@ilkilic ilkilic merged commit 227015c into main Nov 26, 2024
6 checks passed
@ilkilic ilkilic deleted the iv-fi-sim branch November 26, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants