-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simulated values to IV and FI plots for comparison with experimental data #177
Conversation
…ntal data for comparison
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
==========================================
- Coverage 60.07% 52.06% -8.02%
==========================================
Files 109 124 +15
Lines 7838 10569 +2731
==========================================
+ Hits 4709 5503 +794
- Misses 3129 5066 +1937 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Will this work for non-rheobase type optimisations?
@darshanmandge we do not support non-rheobase type optimisations for those plots. I have added a warning to clarify it |
Just to clarify for other users: this PR adds the additional simulated data points for comparing the experimental and simulated IV and FI curves at regular intervals of stimulus amplitudes on the x-axis. |
@darshanmandge Sorry if it was not clear before, but for non-rheobase type optimisations, the plots are not generated at all. I have updated the PR description to clarify this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
This PR enhances IV and FI plots by adding simulated data points at regular intervals for better comparison of experimental and simulated data. These plots are only generated for rheobase type optimisations, and a warning clarifies that they will not be plotted for non-rheobase cases.