Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add settings for customisable plots #176

Merged
merged 4 commits into from
Nov 11, 2024
Merged

add settings for customisable plots #176

merged 4 commits into from
Nov 11, 2024

Conversation

AurelienJaquier
Copy link
Collaborator

@AurelienJaquier AurelienJaquier commented Nov 8, 2024

We can now choose to plot -or not- the following using settings: plot_parameter_evolution, plot_distributions, plot_traces, plot_scores, plot_thumbnail, plot_dendritic_ISI_CV, plot_dendritic_rheobase

The default has been kept the same

Now, luigi pipeline will also take these settings into account

PlotModels in luigi pipeline will be called if any of the following is True (for historical reasons, also for simplicity): plot_parameter_evolution, plot_distributions, plot_scores, plot_traces

plot_optimisation has been kept for legacy compatibility reason, but is no longer used

Has removed the distribution plot in EModelCreationWrapper. It was there for no reason, and distribution was already plotted in PlotModels anyway.

Jaquier Aurélien Tristan added 2 commits November 8, 2024 17:29
Change-Id: I047f879e4e0adee206c9209aac7c6a104d5f47c2
Change-Id: Id47249d66806e2e3eeaac9a248ecf13cb043c7c9
@AurelienJaquier AurelienJaquier self-assigned this Nov 8, 2024
Jaquier Aurélien Tristan added 2 commits November 11, 2024 09:47
Change-Id: If43bdfdf9eb110a107e2d9725dbce8e3d32a8381
Change-Id: I5f4639070fb113a20428c5a097b9f9d9785f90cd
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.92593% with 20 lines in your changes missing coverage. Please review.

Project coverage is 52.38%. Comparing base (8d5b0ab) to head (f498f1e).
Report is 121 commits behind head on main.

Files with missing lines Patch % Lines
bluepyemodel/tasks/emodel_creation/optimisation.py 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
- Coverage   60.07%   52.38%   -7.69%     
==========================================
  Files         109      124      +15     
  Lines        7838    10464    +2626     
==========================================
+ Hits         4709     5482     +773     
- Misses       3129     4982    +1853     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AurelienJaquier AurelienJaquier merged commit 900d810 into main Nov 11, 2024
6 checks passed
@AurelienJaquier AurelienJaquier deleted the plot-settings branch November 11, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants