add aliases to match substrait "substring" and "string_split"

datafusion/functions-array/src/string.rs

@@ -184,7 +184,7 @@ impl StringToArray {
                 ],
                 Volatility::Immutable,
             ),
-            aliases: vec![String::from("string_to_list")],
+            aliases: vec![String::from("string_to_list"), String::from("string_split")],
         }
     }
 }

datafusion/functions/src/unicode/substr.rs

@@ -32,6 +32,7 @@ use crate::utils::{make_scalar_function, utf8_to_str_type};
 #[derive(Debug)]
 pub struct SubstrFunc {
     signature: Signature,
+    aliases: Vec<String>,
 }
 
 impl Default for SubstrFunc {
@@ -53,6 +54,7 @@ impl SubstrFunc {
                 ],
                 Volatility::Immutable,
             ),
+            aliases: vec![String::from("substring")],
         }
     }
 }
@@ -66,6 +68,10 @@ impl ScalarUDFImpl for SubstrFunc {
         "substr"
     }
 
+    fn aliases(&self) -> &[String] {
+        &self.aliases
+    }
+
     fn signature(&self) -> &Signature {
         &self.signature
     }

datafusion/sqllogictest/test_files/array.slt

@@ -6471,6 +6471,19 @@ select string_to_list(e, 'm') from values;
 [adipiscing]
 NULL
 
+query ?
+select string_split(e, 'm') from values;
+----
+[Lore, ]
+[ipsu, ]
+[dolor]
+[sit]
+[a, et]
+[,]
+[consectetur]
+[adipiscing]
+NULL
+
 # array_resize scalar function #1
 query ?
 select array_resize(make_array(1, 2, 3), 1);

datafusion/sqllogictest/test_files/functions.slt

@@ -383,6 +383,12 @@ SELECT substr('alphabet', 3)
 ----
 phabet
 
+# Alias for substr
+query T
+SELECT substring('alphabet', 3)
+----
+phabet
+
 query T
 SELECT substr('alphabet', 30)
 ----