Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft:intermediary-relations #75

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lveillard
Copy link
Member

@lveillard lveillard commented Jun 19, 2024

🚀 This description was created by Ellipsis for commit 285d982

Summary:

Introduced intermediary relations handling in BQL mutations with updates to core files and unit tests.

Key points:

  • package.json: Updated test:typedb-mutation script to run typedb/unit/mutations/basic.test.ts.
  • src/helpers.ts: Added logic to handle intermediary relations in enrichSchema function.
  • src/stateMachine/mutation/bql/enrichSteps/addIntermediaryRelations.ts: New file to handle intermediary relations in BQL mutations.
  • src/stateMachine/mutation/bql/intermediary.ts: Added traversal logic to integrate intermediary relations.
  • src/stateMachine/mutation/bql/parse.ts: Updated parsing logic to handle intermediary relations.
  • src/stateMachine/mutation/mutationMachine.ts: Integrated intermediary relations step in the mutation state machine.
  • src/stateMachine/mutation/tql/run.ts: Minor logging changes.
  • src/stateMachine/query/bql/enrich.ts: Minor fix for oppositeLinkFieldsPlayedBy mapping.
  • tests/unit/mutations/basic.ts: Added and updated tests to cover intermediary relations handling.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 285d982 in 1 minute and 24 seconds

More details
  • Looked at 526 lines of code in 9 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_rfv6kzCdizAFU0Jx


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@@ -2,7 +2,7 @@ import { v4 as uuidv4 } from 'uuid';

import { deepSort, expectArraysInObjectToContainSameElements } from '../../helpers/matchers';
import { createTest } from '../../helpers/createTest';
import { expect, it } from 'vitest';
import { expect, expect, it } from 'vitest';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the duplicated import of expect from vitest to clean up the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant