Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port multiple master-targeted fixes to janus release branch #56

Closed
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
4287126
correct python3 comparison operator
slowriot Aug 19, 2021
82be88a
enable building tests by default, external signer default to match bi…
slowriot Aug 20, 2021
dc7c5ae
reinstate valid base58 test data and test methodology from bitcoin core
slowriot Sep 1, 2021
5bcd84e
declare classes final where appropriate, to enable devirtualisation o…
slowriot Aug 20, 2021
d9d0c9a
add warning to suggest attribute noreturn if applicable
slowriot Sep 1, 2021
cadbc14
add warning to suggest attribute const and placeholder warning for at…
slowriot Aug 21, 2021
7413615
add single warning for "unused" warning options
slowriot Aug 21, 2021
bcc5729
add attribute [[maybe_unused]] to mark parameters that are known not …
slowriot Aug 21, 2021
74e3558
remove unused debugging includes
slowriot Aug 20, 2021
602e578
use C++17 fallthrough attributes instead of comments, resolve fallthr…
slowriot Aug 20, 2021
53702ef
add modern fallthrough attribute, replace old hacky solutions
slowriot Aug 20, 2021
1153e5f
tidy and remove unneeded braces for cases that don't require them
slowriot Aug 20, 2021
bb7b45a
add warning for non-virtual destructor in base class, and fix all ins…
slowriot Aug 20, 2021
b302246
add extra performance and safety compiler warnings
slowriot Aug 20, 2021
8fc8b6e
add warning for implicit double promotion
slowriot Aug 20, 2021
fe178e9
avoid unnecessary double promotion in calculating time interval, and …
slowriot Aug 20, 2021
e5e2f10
avoid implicit conversions that may alter a value, or make them expli…
slowriot Aug 20, 2021
641b656
placeholder warnings for conversion and useless casts
slowriot Aug 24, 2021
2e9f261
do not enable DEBUG_LOCKORDER for all debug builds; the code associat…
slowriot Aug 24, 2021
e82c875
remove unused includes
slowriot Aug 25, 2021
06c8771
don't disable implicit-fallthrough warning (this is now dealt with in…
slowriot Aug 24, 2021
fbc5630
re-enable asserts for signet chain params at creation, with correct g…
slowriot Aug 25, 2021
47d9edd
remove unused include
slowriot Aug 25, 2021
333e731
add tests to verify test addresses are valid - this also tests the va…
slowriot Aug 25, 2021
24b4b53
add a test to ensure a BTC address does not count as a valid destination
slowriot Aug 25, 2021
f97a386
enable building tests by default, external signer default to match bi…
slowriot Aug 20, 2021
0743fd2
don't disable implicit-fallthrough warning (this is now dealt with in…
slowriot Aug 24, 2021
5dd71f1
update benchmark decode address to BGL prefix for consistency
slowriot Aug 25, 2021
242d656
update test data sample BTC address to BGL format with prefix 10
slowriot Aug 25, 2021
0d0d37b
some tests use the pubkey of the BTC genesis block - update these to …
slowriot Aug 25, 2021
c6bb29c
Revert "don't disable implicit-fallthrough warning (this is now dealt…
slowriot Sep 1, 2021
53de81b
remove attribute final from classes Sock, CCoinsViewCache, Descriptor…
slowriot Sep 1, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unused includes
  • Loading branch information
slowriot committed Sep 1, 2021
commit e82c875679edef6c88aac0d3dbb85c50b2e9ea61
1 change: 0 additions & 1 deletion src/crypto/chacha_poly_aead.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#include <assert.h>
#include <string.h>

#include <cstdio>
#include <limits>

#ifndef HAVE_TIMINGSAFE_BCMP
Expand Down
1 change: 0 additions & 1 deletion src/crypto/muhash.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
#include <hash.h>

#include <cassert>
#include <cstdio>
#include <limits>

namespace {
Expand Down
2 changes: 0 additions & 2 deletions src/policy/settings.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@

#include <logging.h>

#include <cstdio>

class CFeeRate;
class CTransaction;

Expand Down
3 changes: 0 additions & 3 deletions src/pow.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.

#include <pow.h>

#include <cstdio>

#include <arith_uint256.h>
#include <chain.h>
#include <primitives/block.h>
Expand Down
1 change: 0 additions & 1 deletion src/test/fuzz/util.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
#include <algorithm>
#include <array>
#include <cstdint>
#include <cstdio>
#include <optional>
#include <string>
#include <vector>
Expand Down