Skip to content
This repository has been archived by the owner on Feb 17, 2025. It is now read-only.

Migrate to Vue 3 #31

Merged
merged 7 commits into from
Feb 7, 2023
Merged

Migrate to Vue 3 #31

merged 7 commits into from
Feb 7, 2023

Conversation

evamillan
Copy link
Contributor

This PR upgrades the Vue version to 3.1.0. It also installs some libraries that will be needed in the future or changes them to follow the new recommendations:

  • Vue CLI is in maintenance mode, the recommended build tool is Vite. The UI can be built and served with the same commands ỳarn build and yarn serve. Vite also adds yarn preview to locally preview production build.
  • Installed Vuetify and Storybook and added a test component and a story to check that they worked and to see the changes with the previous versions.
  • Vitest is the recommended tool for unit testing instead of Jest. Theoretically, Jest can be made to work with Vite, but the package they recommend to integrate it hasn't been updated in 2 years and I couldn't get it to work with Vuetify. Since Storyshots (the library we use in SortingHat to test Storybook snapshots) only works with Jest, we need a workaround to generate a snapshot test for every Storybook story like Storyshots does.

Vite is the new recommended bundler for Vue, and Vue
CLI is now in maintenance.

Signed-off-by: Eva Millán <evamillan@bitergia.com>
Upgrades Vue to version 3.1.0.

Signed-off-by: Eva Millán <evamillan@bitergia.com>
Installs the packages needed to run ESLint and fixes
the errors and warnings raised by the linter.

Signed-off-by: Eva Millán <evamillan@bitergia.com>
Installs Vuetify as a plugin and adds the TaskCard
component to check the differences with the previous
Vuetify versions.

Signed-off-by: Eva Millán <evamillan@bitergia.com>
Installs Storybook and adds a sample story.

Signed-off-by: Eva Millán <evamillan@bitergia.com>
Installs Vitest for unit testing and Cypress for
end to end tests.
Adds storybook.spec.js, which generates a test
for each Storybook story in a similar way to
Storyshots.

Signed-off-by: Eva Millán <evamillan@bitergia.com>
Signed-off-by: Eva Millán <evamillan@bitergia.com>
Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sduenas sduenas merged commit 9c1ebf2 into Bitergia:master Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants