Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Cashflow screen #224

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: Cashflow screen #224

wants to merge 7 commits into from

Conversation

mjkeaton
Copy link
Collaborator

@mjkeaton mjkeaton commented Jan 9, 2025 •
edited
Loading

📝 Description

Relates to #220

Storybook: http://localhost:6006/?path=/story/element-cashflowchart--default

Differences to Figma:

  • It was decided to make the line grey (instead of green as in Figma).
  • axis labels not yet matching
  • Tooltip not yet matching

📸 Screenshots/Screen record (if applicable)

@mjkeaton mjkeaton self-assigned this Jan 9, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
e-bill-frontend ✅ Ready (Inspect) Visit Preview Jan 9, 2025 5:29pm

@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0.74906% with 265 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pages/home/components/CashFlowChart.tsx 0.00% 130 Missing ⚠️
src/pages/home/CashFlow.tsx 0.00% 58 Missing ⚠️
...rc/pages/home/components/CashFlowChart.stories.tsx 0.00% 49 Missing ⚠️
src/pages/home/components/CurrencySelector.tsx 0.00% 12 Missing ⚠️
src/pages/home/components/Bills.tsx 0.00% 8 Missing ⚠️
src/main.tsx 0.00% 5 Missing ⚠️
src/pages/home/components/Balances.tsx 0.00% 2 Missing ⚠️
src/mocks/handlers/bills/list.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@mjkeaton mjkeaton requested a review from cryptosalomao January 9, 2025 17:53
@mjkeaton mjkeaton marked this pull request as ready for review January 9, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptosalomao cryptosalomao Awaiting requested review from cryptosalomao

At least 1 approving review is required to merge this pull request.

Assignees

@mjkeaton mjkeaton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mjkeaton