Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): enable crowdin in-context tool in dedicated vercel env #219

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

mjkeaton
Copy link
Collaborator

@mjkeaton mjkeaton commented Jan 7, 2025

This PR adds a new build command build:crowdin that builds the application with crowdin in-context tooling enabled.

The behaviour of the env var VITE_BITCR_DEV_INCLUDE_CROWIN_IN_CONTEXT_TOOLING has been changed from "opt-out" to "opt-in", i.e. it must be "true" for the in-context tool to be active.

Additionally, a vercel.sh has been added that invokes the different build scripts for different environments.

URL with crowdin in-context support:
https://e-bill-frontend-crowdin.vercel.app/

URL without crowdin in-context support:
https://e-bill-frontend.vercel.app/

Additionally, the command dev:build has been renamed to build:dev for consistency.

After this PR is merged, the build command in the web app has to be adapted (custom command removed, as we adapt buildCommand in vercel.json).

@mjkeaton mjkeaton added devOps DevOps tasks enhancement Enhancement of existing code labels Jan 7, 2025
@mjkeaton mjkeaton self-assigned this Jan 7, 2025
Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
e-bill-frontend ✅ Ready (Inspect) Visit Preview Jan 8, 2025 9:22am

package.json Outdated Show resolved Hide resolved
vite.config.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@cryptosalomao cryptosalomao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor misspelling, but LGTM

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@mjkeaton mjkeaton merged commit 65b5fd8 into main Jan 8, 2025
5 checks passed
@mjkeaton mjkeaton deleted the chore/crowdin-deploy branch January 8, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devOps DevOps tasks enhancement Enhancement of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants