Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUIP018 Seeding #30

Merged
merged 4 commits into from
Jun 9, 2016
Merged

BUIP018 Seeding #30

merged 4 commits into from
Jun 9, 2016

Conversation

bitcartel
Copy link
Contributor

Bitnodes API seeding and user-configurable DNS seeds.
https://bitco.in/forum/threads/buip018-seeding.1065/

bitcartel added 4 commits April 1, 2016 20:45
@bitcartel
Disable fixed seeds in Mainnet.
2f6e5cc
@bitcartel
Update DNS seed list.
362308a
@bitcartel
- Add feature to seed client by retrieving a list of nodes from
8e819ce 
  Bitnodes.21.co using the Bitnodes API.  This provides an alternative to DNS seeding.
- Add command-line option 'bitnodes', enabled by default.
- Add command-line option 'forcebitnodes', disabled by default.
@bitcartel
DNS seeds are user-configurable via command-line option 'usednsseed'.
3b766e8 
If at least one custom DNS seed is set, the default DNS seeds are
ignored.
gandrewstone
gandrewstone reviewed Jun 8, 2016
View reviewed changes
src/net.cpp
// Get nodes from websites offering Bitnodes API
if ((addrman.size() > 0) &&
(!GetBoolArg("-forcebitnodes", DEFAULT_FORCEBITNODES))) {
MilliSleep(11 * 1000);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 11 seconds?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a magic number. For consistency I used the same value as found in ThreadDNSAddressSeed().

https://github.com/BitcoinUnlimited/BitcoinUnlimited/blob/0.12bu/src/net.cpp#L1400

@gandrewstone gandrewstone merged commit 3b766e8 into BitcoinUnlimited:0.12bu Jun 9, 2016
@gandrewstone
Copy link
Collaborator

Awesome, thx for the submission!

@rebroad
Copy link
Contributor

rebroad commented Sep 22, 2016

I like this feature - I'm trying to get it to work on Bitcoin Core but it doesn't compile easily for some reason :-s

@ptschip
Copy link
Collaborator

ptschip commented Sep 22, 2016

it might be your boost version...i think this only works on boost 1.59
or above

On 22/09/2016 6:14 AM, R E Broadley wrote:

I like this feature - I'm trying to get it to work on Bitcoin Core but
it doesn't compile easily for some reason :-s

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#30 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMRF0EgtRCRmCKvWGksMjnY9xOuKP1FCks5qsn85gaJpZM4H-N_S.

@ptschip ptschip mentioned this pull request Oct 11, 2016
Closed
Greg-Griffith pushed a commit to Greg-Griffith/BitcoinUnlimited that referenced this pull request Jun 2, 2020
@bissias
Merge pull request BitcoinUnlimited#30 from bissias/no_more_cdeltablock
1651a45 
Remove references to CDeltaBlock outside deltablocks files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bitcartel @gandrewstone @rebroad @ptschip