Skip to content
This repository has been archived by the owner on Oct 8, 2024. It is now read-only.

promtail/files/promtail.yaml: Removed filenames at additional stages to prevent cardinality explosion #63

Merged

Conversation

bjmask
Copy link
Contributor

@bjmask bjmask commented Sep 14, 2022

No description provided.

@jimethn jimethn merged commit 58873c2 into BitGo:master Sep 14, 2022
@james-callahan
Copy link
Contributor

Why do we need the label drop in two places?
Surely we should only need it in either pipeline_stages or relabel_configs, not both?

@jimethn
Copy link
Contributor

jimethn commented Sep 15, 2022

@james-callahan the docs are not very clear and this is where we landed after hours of trial and error 😅

It's possible we could reduce to just one or the other, I don't remember all the different permutations we tried anymore...

@james-callahan
Copy link
Contributor

Helpful comment over at grafana/loki#3813 (comment)
Only the one in pipeline_stages should be required.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants