Leverage constants from BitGoJS.statics #65
Conversation
Use decimals from BitGoJS.statics in the following functions: - handleSignUtxo - signEthTx - handleSignXrp Use networks from BitGoJS.statics in the following functions: - handleSignUtxo
app/sign.js
Outdated
|
|
||
| // const network = utxoNetworks[recoveryRequest.coin]; | ||
| // const decimals = coinDecimals[recoveryRequest.coin]; | ||
| const network = statics.coins.get[recoveryRequest.coin].network; |
There was a problem hiding this comment.
Might be worth adding an alias getCoinConfig(coin) to avoid having to write statics.coins.get[x] over and over
There was a problem hiding this comment.
Good point, but consider it only used 4 times in this file so I didn't bother
There was a problem hiding this comment.
Added. Not sure if this is the optimal way tho.
1730b1b
Using getCoinConfig(coin, data) instead of statics.coins.get[coin].data BitGo#61
app/sign.js
Outdated
|
|
||
| const BCH_COINS = ['bch', 'tbch', 'bsv', 'tbsv']; | ||
| const TEN = new BN(10); | ||
|
|
||
| const EOS_MAINNET_CHAIN_ID = 'aca376f206b8fc25a6ed44dbdc66547c36c6c33e3a119ffbeaef943642f0e906'; | ||
| const EOS_TESTNET_CHAIN_ID = 'e70aaab8997e1dfce58fbfac80cbbb8fecec7b99cf982a9444273cbc64c41473'; | ||
|
|
||
| const getCoinConfig = function(coin, data) { | ||
| return statics.coins.get[coin].data; |
There was a problem hiding this comment.
I think .data tries to get the key "data" out of the object, not the actual key passed as a param. Maybe you want to use [data]
There was a problem hiding this comment.
Oh yeah. Didn't notice this is a reserved keyword
app/sign.js
Outdated
| const network = utxoNetworks[recoveryRequest.coin]; | ||
| const decimals = coinDecimals[recoveryRequest.coin]; | ||
|
|
||
| const network = getCoinConfig(recoveryRequest.coin, network); |
There was a problem hiding this comment.
Are network and decimalPlaces defined here? Maybe you wanted to use string keys.
There was a problem hiding this comment.
Thanks for notice. I change the type var to string for network and decimalPlaces. Can you check if the lastest commit is legit? Haven't coded in JS for a long time so need to catch up its syntax.
cb650e8
Change var to string
Motivation
Use existing constants from BitGoJS.statics
Overview Of Changes
Use
decimalsfromBitGoJS.staticsin the following functions:handleSignUtxosignEthTxhandleSignXrpUse
networksfromBitGoJS.staticsin the following function:handleSignUtxo