-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add github workflow #848
Conversation
@@ -52,7 +52,7 @@ osx: | |||
mv build/BitBox.app build/osx/ | |||
cp resources/MacOS/Info.plist build/osx/BitBox.app/Contents/ | |||
cp resources/MacOS/icon.icns build/osx/BitBox.app/Contents/Resources/ | |||
macdeployqt build/osx/BitBox.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spurious trailing slash was causing macdeployqt to fail on github macos runner.
Not sure where it was coming from but it doesn't seem to be required according to https://doc.qt.io/qt-5/macos-deployment.html.
Can you explain again what is going on with the vendoring? Cause Is Go 1.14 forcing a dep update? If so, let's update Go properly in the Dockerfile? |
Tried doing that here (might be independent, but was about time anyway): |
I remember there was a change in Go 1.14 which was not backported to 1.13. The change made
Yeah, I would expect exactly that on 1.13.
Yes. It complains otherwise,
Right, it's independent. I would expect updated deps to work with both 1.13 and 1.14. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
I'll wait for #850 and then rebase. Feels like deps sync belongs more to that than this PR. |
Alternative to Travis CI. Runs the same scripts except SSH for nightly builds.
Ok. Removed the sync deps commit but forgot to sign. |
Alternative to Travis CI.
Runs the same scripts except SSH for nightly builds.