Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add github workflow #848

Merged
merged 1 commit into from
Jun 11, 2020
Merged

ci: add github workflow #848

merged 1 commit into from
Jun 11, 2020

Conversation

x1ddos
Copy link
Contributor

@x1ddos x1ddos commented Jun 6, 2020

Alternative to Travis CI.
Runs the same scripts except SSH for nightly builds.

@x1ddos x1ddos requested a review from benma June 6, 2020 22:20
@@ -52,7 +52,7 @@ osx:
mv build/BitBox.app build/osx/
cp resources/MacOS/Info.plist build/osx/BitBox.app/Contents/
cp resources/MacOS/icon.icns build/osx/BitBox.app/Contents/Resources/
macdeployqt build/osx/BitBox.app/
Copy link
Contributor Author

@x1ddos x1ddos Jun 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spurious trailing slash was causing macdeployqt to fail on github macos runner.
Not sure where it was coming from but it doesn't seem to be required according to https://doc.qt.io/qt-5/macos-deployment.html.

@benma
Copy link
Contributor

benma commented Jun 7, 2020

Can you explain again what is going on with the vendoring?

Cause make go-vendor does not change anything when I run it locally.

Is Go 1.14 forcing a dep update?

If so, let's update Go properly in the Dockerfile?

@benma
Copy link
Contributor

benma commented Jun 7, 2020

If so, let's update Go properly in the Dockerfile?

Tried doing that here (might be independent, but was about time anyway):

#850

@x1ddos
Copy link
Contributor Author

x1ddos commented Jun 7, 2020

I remember there was a change in Go 1.14 which was not backported to 1.13. The change made go mod vendor add all transitive deps where 1.13 would sometimes skip it. This results in 1.14 arriving at different deps versions where 1.13 just wouldn't care and skip. This is my understanding. It's buried somewhere in golang/go#33848 (comment). Release notes https://golang.org/doc/go1.14#tools don't mention this inconsistency either.

Cause make go-vendor does not change anything when I run it locally.

Yeah, I would expect exactly that on 1.13.

Is Go 1.14 forcing a dep update?

Yes. It complains otherwise,

If so, let's update Go properly in the Dockerfile?

Right, it's independent. I would expect updated deps to work with both 1.13 and 1.14.

Copy link
Contributor

@benma benma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@x1ddos
Copy link
Contributor Author

x1ddos commented Jun 7, 2020

I'll wait for #850 and then rebase. Feels like deps sync belongs more to that than this PR.

@x1ddos x1ddos mentioned this pull request Jun 11, 2020
Alternative to Travis CI.
Runs the same scripts except SSH for nightly builds.
@x1ddos
Copy link
Contributor Author

x1ddos commented Jun 11, 2020

Ok. Removed the sync deps commit but forgot to sign.

@x1ddos x1ddos merged commit a12ee2a into master Jun 11, 2020
@x1ddos x1ddos deleted the github-ci branch June 11, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants