Java: Add HSCAN command #401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is pointing to the dev branch for zscan (which includes sscan) temporarily. |
|
The NOVALUES flag was added in Redis 7.2.5 but not marked as such. We will not implement this for now. |
GumpacG
approved these changes
Jun 28, 2024
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/integTest/src/test/java/glide/TransactionTestUtilities.java
Outdated
Show resolved
Hide resolved
1c60c2b to
57505dc
Compare
yipin-chen
approved these changes
Jun 28, 2024
acarbonetto
reviewed
Jun 28, 2024
| * and ZSCAN). | ||
| */ | ||
| @SuperBuilder | ||
| public abstract class ScanOptions { |
There was a problem hiding this comment.
would you be able to rename to BaseScanOptions? As per the description (that already calls it base class).
We can then add ScanOptions for the Scan command itself.
There was a problem hiding this comment.
Sure. Did you want to do that here or in the ZScan PRs? Actually, do you want to put this in the same integration branch @acarbonetto
e8bb5ad to
5c26630
Compare
4ac1fb1 to
db453b2
Compare
4973082 to
5df2e0b
Compare
5df2e0b to
fe1493a
Compare
|
Closing this as it is no longer necessary. valkey-io#1706 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.