Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test data for relevancy search integration tests #90

Conversation

Yury-Fridlyand
Copy link

Description

  • Reduce test data set
  • Update tests according to new data set
  • Add new tests which validate additional parameters
  • Reorganize (rename, move) tests to have them stored under single standard

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

opensearch-trigger-bot bot and others added 15 commits April 19, 2022 18:10
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
(cherry picked from commit 0ae97ad)

Co-authored-by: Yaliang Wu <ylwu@amazon.com>
…t#585)

* 2.0.0.0-rc1 release notes

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
(cherry picked from commit 4c7111a)

Co-authored-by: vamsi-amazon <99925918+vamsi-amazon@users.noreply.github.com>
…pensearch-project#589)

Signed-off-by: Joshua Li <joshuali925@gmail.com>
(cherry picked from commit a7d4395)

Co-authored-by: Joshua Li <joshuali925@gmail.com>
* Remove rc1 qualifier for 2.0

Signed-off-by: Joshua Li <joshuali925@gmail.com>
(cherry picked from commit d71cddc)
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
(cherry picked from commit 14fc606)
… HEAD

� Conflicts:
�	build.gradle
�	workbench/opensearch_dashboards.json
�	workbench/package.json
…_String. Added implementation for simple_query_string to use multiple flags seperated by pipes.

Signed-off-by: mitchellg <mitchellg@bitquilltech.com>
…_String. Added implementation for simple_query_string to use multiple flags seperated by pipes.

Signed-off-by: mitchellg <mitchellg@bitquilltech.com>
Signed-off-by: mitchellg <mitchellg@bitquilltech.com>
Signed-off-by: mitchellg <mitchellg@bitquilltech.com>
Signed-off-by: mitchellg <mitchellg@bitquilltech.com>
…gsinSimpleQueryString

Adds support for enum like values in flag argument in Simple Query String
… Integ-enumLikeValuesdSupprtForFalsinSimpleQueryString
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
@Yury-Fridlyand Yury-Fridlyand requested a review from a team July 18, 2022 20:15
@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #90 (951a717) into integ-update-test-data-relevancy-search (3f545f2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@                            Coverage Diff                             @@
##             integ-update-test-data-relevancy-search      #90   +/-   ##
==========================================================================
  Coverage                                      97.74%   97.74%           
- Complexity                                      2857     2858    +1     
==========================================================================
  Files                                            273      273           
  Lines                                           7018     7020    +2     
  Branches                                         442      442           
==========================================================================
+ Hits                                            6860     6862    +2     
  Misses                                           157      157           
  Partials                                           1        1           
Flag Coverage Δ
sql-engine 97.74% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ilter/lucene/relevance/SimpleQueryStringQuery.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
@Yury-Fridlyand
Copy link
Author

I'd like to update few tests once opensearch-project#695 merged.

…lsinSimpleQueryString' into dev-update-test-data-relevancy-search

Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
@Yury-Fridlyand Yury-Fridlyand merged commit 2dcb002 into integ-update-test-data-relevancy-search Jul 22, 2022
@Yury-Fridlyand Yury-Fridlyand deleted the dev-update-test-data-relevancy-search branch July 22, 2022 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants