Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for nested expression serialization #249

Closed

Conversation

MaxKsyunz
Copy link

Description

Work-in-progress that removes double-base64 encoding of serialized physical plans. This was increasing size unnecessarily.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #249 (ba9130a) into dev-pagination-v2_revC (ec5fb40) will decrease coverage by 0.26%.
The diff coverage is 96.77%.

@@                     Coverage Diff                      @@
##             dev-pagination-v2_revC     #249      +/-   ##
============================================================
- Coverage                     98.44%   98.18%   -0.26%     
+ Complexity                     3844     3841       -3     
============================================================
  Files                           359      360       +1     
  Lines                          9431     9439       +8     
  Branches                        615      615              
============================================================
- Hits                           9284     9268      -16     
- Misses                          142      164      +22     
- Partials                          5        7       +2     
Flag Coverage Δ
sql-engine 98.18% <96.77%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rg/opensearch/sql/executor/PaginatedPlanCache.java 77.27% <90.00%> (-22.73%) ⬇️
...ion/serialization/DefaultExpressionSerializer.java 100.00% <100.00%> (ø)
...on/serialization/NoEncodeExpressionSerializer.java 100.00% <100.00%> (ø)
...ensearch/sql/planner/physical/ProjectOperator.java 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant