Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Like Query should use WildcardQuery #220

Closed
wants to merge 1 commit into from

Conversation

GumpacG
Copy link

@GumpacG GumpacG commented Feb 6, 2023

Signed-off-by: Guian Gumpac guian.gumpac@improving.com

Description

Made LIKE query use WildcardQuery.
Discussion about this can be found in opensearch-project#1143 and opensearch-project#1108 (comment)

Issues Resolved

opensearch-project#1143

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

❗ No coverage uploaded for pull request base (integ-like-query@af188a3). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##             integ-like-query     #220   +/-   ##
===================================================
  Coverage                    ?   98.36%           
  Complexity                  ?     3640           
===================================================
  Files                       ?      342           
  Lines                       ?     9009           
  Branches                    ?      585           
===================================================
  Hits                        ?     8862           
  Misses                      ?      142           
  Partials                    ?        5           
Flag Coverage Δ
sql-engine 98.36% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@GumpacG
Copy link
Author

GumpacG commented Feb 10, 2023

Closing this PR to declutter the PR list as this is currently paused.
This should be reopened once opensearch-project#1143 is ready to be executed on.

@GumpacG GumpacG closed this Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants