-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub workflow to pack BI connectors #19
Changes from 15 commits
396ce1c
1d3cceb
c277fe2
2be30f3
604adbf
91dd569
6b89593
015fa7b
081392e
450d483
a62bdd1
47530d0
21e0bdf
f5692cc
a432ac2
f53a46d
4cadfd1
6e37870
ccb52f4
2e67626
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
name: Build connectors for BI tools | ||
|
||
on: | ||
push: | ||
paths: | ||
- 'bi-connectors/PowerBIConnector/**' | ||
- 'bi-connectors/TableauConnector/**' | ||
- '.github/workflows/bi-connectors.yml' | ||
|
||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v1 | ||
- name: Pack Tableau ODBC connector | ||
id: pack-tableau-odbc | ||
run: | | ||
zip -r opensearch_sql_odbc.taco . -x *.taco | ||
working-directory: bi-connectors/TableauConnector/opensearch_sql_odbc | ||
- name: Pack Tableau JDBC connector | ||
id: pack-tableau-jdbc | ||
run: | | ||
zip -r opensearch_sql_jdbc.taco . -x *.taco | ||
working-directory: bi-connectors/TableauConnector/opensearch_sql_jdbc | ||
- name: Prepare Power BI ODBC connector | ||
run: | | ||
cp SqlOdbcPBIConnector.pq SqlOdbcPBIConnector.m | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are these names right after the rebranding that occurred? |
||
working-directory: bi-connectors/PowerBIConnector | ||
- name: Pack Power BI ODBC connector | ||
id: pack-powerbi-odbc-os-proj | ||
run: | | ||
zip OpenSearchProject.mez *.png *.m *.resx *.pqm | ||
working-directory: bi-connectors/PowerBIConnector | ||
- name: Prepare the second Power BI ODBC connector | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the second one...? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There are 2 connector requested by Amazon: one for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you then name them accordingly instead of "the second one"? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changed in 6e37870. |
||
id: prep-powerbi-odbc-amz-os-svc | ||
run: | | ||
sed -i 's/<value>OpenSearch Project<\/value>/<value>Amazon OpenSearch Service<\/value>/g' resources.resx | ||
sed -i 's/Documentation.Name = "OpenSearch Project"/Documentation.Name = "Amazon OpenSearch Service"/g' SqlOdbcPBIConnector.m | ||
sed -i 's/SqlOdbcPBIConnector\([^1-9]\)/AmazonOpenSearchConnector\1/g' SqlOdbcPBIConnector.m | ||
working-directory: bi-connectors/PowerBIConnector | ||
- name: Pack Power BI ODBC connector for 'Amazon OpenSearch Service' | ||
id: pack-powerbi-odbc-amz-os-svc | ||
run: | | ||
zip AmazonOpenSearchService.mez *.png *.m *.resx *.pqm | ||
working-directory: bi-connectors/PowerBIConnector | ||
- name: Upload Tableau ODBC connector | ||
if: steps.pack-tableau-odbc.outcome == 'success' | ||
uses: actions/upload-artifact@v2 | ||
with: | ||
name: TableauConnectors | ||
path: bi-connectors/TableauConnector/opensearch_sql_odbc/opensearch_sql_odbc.taco | ||
- name: Upload Tableau JDBC connector | ||
if: steps.pack-tableau-jdbc.outcome == 'success' | ||
uses: actions/upload-artifact@v2 | ||
with: | ||
name: TableauConnectors | ||
path: bi-connectors/TableauConnector/opensearch_sql_jdbc/opensearch_sql_jdbc.taco | ||
- name: Upload Power BI ODBC connectors | ||
if: steps.pack-powerbi-odbc-os-proj.outcome == 'success' || (steps.prep-powerbi-odbc-amz-os-svc.outcome == 'success' && steps.pack-powerbi-odbc-amz-os-svc.outcome == 'success') | ||
uses: actions/upload-artifact@v2 | ||
with: | ||
name: PBIConnectors | ||
path: 'bi-connectors/PowerBIConnector/*.mez' |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,7 @@ SqlOdbcPBIConnectorType = type function ( | |
]) | ||
) | ||
as table meta [ | ||
Documentation.Name = "OpenSearch" | ||
Documentation.Name = "OpenSearch Project" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Where are these changes here, they seem unrelated to the GitHub flows? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to Amazon's request we should build 2 connectors: one for |
||
]; | ||
|
||
SqlOdbcPBIConnectorImpl = (Server as text) as table => | ||
|
@@ -159,7 +159,7 @@ OnOdbcError = (errorRecord as record) => | |
else | ||
error errorRecord; | ||
|
||
// Data Source Kind description | ||
// Data Source Kind description. | ||
SqlOdbcPBIConnector = [ | ||
// Required for use with Power BI Service. | ||
TestConnection = (dataSourcePath) => | ||
|
@@ -169,7 +169,7 @@ SqlOdbcPBIConnector = [ | |
in | ||
{ "SqlOdbcPBIConnector.Contents", Server }, | ||
|
||
// Authentication modes | ||
// Authentication modes. | ||
Authentication = [ | ||
Implicit = [ | ||
Label = "NONE" | ||
|
@@ -183,7 +183,7 @@ SqlOdbcPBIConnector = [ | |
] | ||
], | ||
|
||
// PBIDS Handler | ||
// PBIDS Handler. | ||
DSRHandlers = [ | ||
#"sqlodbc" = [ | ||
GetDSR = (server, schema, object, optional options) => [ protocol = "sqlodbc", address = [ server = server ] ], | ||
|
@@ -196,13 +196,13 @@ SqlOdbcPBIConnector = [ | |
] | ||
], | ||
|
||
// Enable Encryption | ||
// Enable Encryption. | ||
SupportsEncryption = true, | ||
|
||
Label = Extension.LoadString("DataSourceLabel") | ||
]; | ||
|
||
// Data Source UI publishing description | ||
// Data Source UI publishing description. | ||
SqlOdbcPBIConnector.Publish = [ | ||
Beta = true, | ||
Category = "Other", | ||
|
@@ -221,15 +221,15 @@ SqlOdbcPBIConnector.Icons = [ | |
Icon32 = { Extension.Contents("SqlOdbcPBIConnector32.png"), Extension.Contents("SqlOdbcPBIConnector40.png"), Extension.Contents("SqlOdbcPBIConnector48.png"), Extension.Contents("SqlOdbcPBIConnector64.png") } | ||
]; | ||
|
||
// Load common library functions | ||
// Load common library functions. | ||
Extension.LoadFunction = (name as text) => | ||
let | ||
binary = Extension.Contents(name), | ||
asText = Text.FromBinary(binary) | ||
in | ||
Expression.Evaluate(asText, #shared); | ||
|
||
// Diagnostics module contains multiple functions. . | ||
// Diagnostics module contains multiple functions. | ||
Diagnostics = Extension.LoadFunction("Diagnostics.pqm"); | ||
Diagnostics.LogValue = if (EnableTraceOutput) then Diagnostics[LogValue] else (prefix, value) => value; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we pack both ODBC and JDBC? I thought we were only going to use JDBC going forward?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script build both for future reference. At the moment, repo already contains a taco for ODBC, so nothing changed for ODBC actually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ODBC one is now deprecated for the JDBC one, we should stop building the ODBC one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disabled in 4cadfd1.