Added a capability to support GROUP BY statement #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQL_GB_GROUP_BY_CONTAINS_SELECT: The GROUP BY clause must contain all nonaggregated columns in the select list. It can contain columns that are not in the select list. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
kylepbit
reviewed
Dec 7, 2021
| @@ -99,6 +99,7 @@ SqlOdbcPBIConnectorImpl = (Server as text) as table => | |||
| SupportsTop = false, | |||
| LimitClauseKind = LimitClauseKind.LimitOffset, | |||
| Sql92Conformance = ODBC[SQL_SC][SQL_SC_SQL92_FULL], | |||
| GroupByCapabilities = ODBC[SQL_GB][SQL_GB_GROUP_BY_CONTAINS_SELECT], | |||
|
This PR is getting closed as group by is supported by the driver thus makes this PR irrelevant. |
MitchellGale
added a commit
that referenced
this pull request
Aug 16, 2023
…project#1972) * Spotless apply on PPL (#339) Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Update ppl/src/test/java/org/opensearch/sql/ppl/parser/AstExpressionBuilderTest.java Co-authored-by: Guian Gumpac <guian.gumpac@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
MitchellGale
added a commit
that referenced
this pull request
Aug 22, 2023
…project#1972) * Spotless apply on PPL (#339) Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Update ppl/src/test/java/org/opensearch/sql/ppl/parser/AstExpressionBuilderTest.java Co-authored-by: Guian Gumpac <guian.gumpac@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
MitchellGale
added a commit
that referenced
this pull request
Aug 22, 2023
…project#1972) * Spotless apply on PPL (#339) Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Update ppl/src/test/java/org/opensearch/sql/ppl/parser/AstExpressionBuilderTest.java Co-authored-by: Guian Gumpac <guian.gumpac@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
MitchellGale
added a commit
that referenced
this pull request
Aug 22, 2023
…project#1972) * Spotless apply on PPL (#339) Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Update ppl/src/test/java/org/opensearch/sql/ppl/parser/AstExpressionBuilderTest.java Co-authored-by: Guian Gumpac <guian.gumpac@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQL_GB_GROUP_BY_CONTAINS_SELECT: The GROUP BY clause must contain all nonaggregated columns in the select list. It can contain columns that are not in the select list.
Signed-off-by: Yury Fridlyand yuryf@bitquilltech.com
Description
Connector reports to PBI that the driver can do grouping in query
MSDN: https://docs.microsoft.com/en-us/sql/odbc/reference/syntax/sqlgetinfo-function?view=sql-server-ver15
Issues Resolved
AOS-235
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.