Simplify logic, call prim.GetPath() once

BigRoy · Nov 29, 2023 · f7235b0 · f7235b0
1 parent 680b1b5
commit f7235b0
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/usd_qtpy/prim_hierarchy.py b/usd_qtpy/prim_hierarchy.py
@@ -36,14 +36,15 @@ def on_context_menu(self, point):
         default_prim = stage.GetDefaultPrim()
         if not parent:
             parent = root
+        parent_path = parent.GetPath()
 
         menu = QtWidgets.QMenu(self)
 
         def create_prim(action):
             type_name = action.text()
 
             # Ensure unique name
-            base_path = parent.GetPath().AppendChild(type_name)
+            base_path = parent_path.AppendChild(type_name)
             prim_path = base_path
             i = 1
             while stage.GetPrimAtPath(prim_path):
@@ -92,7 +93,7 @@ def create_prim(action):
         create_prim_menu.triggered.connect(create_prim)
 
         # Set and clear default prim
-        if parent.GetPath().IsRootPrimPath():
+        if parent_path.IsRootPrimPath():
             # This prim is a primitive directly under root so can be an
             # active prim
             is_default_prim = parent == default_prim
@@ -115,7 +116,7 @@ def create_prim(action):
                 action.triggered.connect(partial(stage.SetDefaultPrim, parent))
 
         # Allow referencing / payloads / variants management
-        if parent != root:
+        if not parent_path.IsAbsoluteRootPath():
             action = menu.addAction("Add reference/payload..")
             action.triggered.connect(partial(
                 self.on_manage_prim_reference_payload, parent)