Using current_user endpoint to fetch the authenticated user #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77a79db to
53b8d7a
Compare
Davit-BetterAngels
approved these changes
Oct 6, 2023
vecchp
reviewed
Oct 9, 2023
vecchp
reviewed
Oct 9, 2023
| @@ -98,7 +96,7 @@ export default function SignIn() { | |||
| } | |||
|
|
|||
| try { | |||
| const tokenResponse = await fetch( | |||
| await fetch( | |||
There was a problem hiding this comment.
May want to make this a constant string somewhere.
antkim003
commented
Oct 9, 2023
| @@ -7,13 +7,25 @@ import { Text, View } from '../components/Themed'; | |||
| export default function TabOneScreen() { | |||
| const { user } = useUser(); | |||
| const { signOut } = useSignOut(); | |||
| // not sure why but this constantly fires over and over again probably a bug w/ how context was set up | |||
| console.log('user', user); | |||
There was a problem hiding this comment.
can we delete this?
vecchp
reviewed
Oct 9, 2023
| const response = await fetch( | ||
| `${process.env['EXPO_PUBLIC_API_URL']}/current-user/`, | ||
| { | ||
| credentials: 'include', |
There was a problem hiding this comment.
After some more reading it is possible we do not want credentials: 'include'. I believe we want to use the default same origin policy. We can update the backend to support this.
I think we'll need to configure
CORS_ALLOWED_ORIGINS = [
"https://sub1.example.com",
"https://sub2.example.com",
]
and
SESSION_COOKIE_DOMAIN = ".example.com"
vecchp
reviewed
Oct 9, 2023
| router.replace('/'); | ||
| } | ||
| } | ||
| const userData = await fetchUser(); |
There was a problem hiding this comment.
We need to have a conversation about the automatic cookie handling in react native.
facebook/react-native#23185
https://stackoverflow.com/a/41637805
https://reactnative.dev/docs/network#known-issues-with-fetch-and-cookie-based-authentication
vecchp
pushed a commit
that referenced
this pull request
Jul 1, 2024
* server, betterangels starting commands * stuck on backend * initial * fetch current user * Added a few things * adding fetch user * chagne back to local host * loop bug fix * adding fetched user endpoint * updated session and user fetch * dev env check * removed log --------- Co-authored-by: Davit-BetterAngels <davit@betterangels.la> Co-authored-by: Davit-BetterAngels <141072810+Davit-BetterAngels@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.